Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95455
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <ca7d2c2b-fa2a-532e-b0e3-b188a1cd79ec@gmx.de>
References: <CANaX5nfGzFsYue8J6yUpNnEYzgUTGj2g-BMWsw1cyahPH=fmmg@mail.gmail.com>
 <CAF+90c_30gzmMXKT0XhZDaTK277uV5edStfka2YVE2ia0xpK9Q@mail.gmail.com>
 <7cdd89c1-3fe5-3455-2f03-d5f6648d93d1@gmx.de> <CANaX5nfTifwbTmNYqZa2i728tCsWEOfadNeVBq5djNmK5fxPpw@mail.gmail.com>
 <ca7d2c2b-fa2a-532e-b0e3-b188a1cd79ec@gmx.de>
Date: Fri, 26 Aug 2016 08:48:39 -0600
Message-ID: <CAFMT4NrdOa9d3NwtriOqztHGY+g+yeeKB2s6yP0NCzVfh_jXHg@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Davey Shafik <davey@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC
From: levim@php.net (Levi Morrison)

On Fri, Aug 26, 2016 at 4:53 AM, Christoph M. Becker <cmbecker69@gmx.de> wr=
ote:
> On 25.08.2016 at 18:37, Davey Shafik wrote:
>
>> On Thu, Aug 25, 2016 at 8:12 PM, Christoph M. Becker <cmbecker69@gmx.de>
>> wrote:
>>
>>> Indeed, the RFC explicitly claims:
>>>
>>> | Behavior of internal functions is not going to be changed.
>>
>> This is correct for functions that had the correct behavior before
>> (everything but array functions).
>>
>> I can remove that part of the change =E2=80=94 but if we're going to cha=
nge it,
>> doing in 7.1 rather than > 7.1 would be best.
>
> AIUI, the actual implementation of the too_few_args RFC does what it
> says, namely to not affect the behavior of internal function at all.
> The issue you've raised is that we have introduced an inconsistency,
> because some internal functions (e.g. array_diff) behave differently.
>
> If that is so, reverting the too_few_args RFC is out of question,
> because not changing the behavior of internal functions was intentional,
> and I assume that everybody who voted on the RFC was aware of that.
>
> The inconsistency between internal functions wrt. to too few/many
> arguments in strict_types mode is not related to the too_few_args RFC at
> all =E2=80=93 we have this as of PHP 7.  Fixing this inconsistency as soo=
n as
> possible might be desirable, but it seems to me that is not even
> possible in the general case, as not all relevant code is under our
> control (think of PECL and even "private" extensions).
>
> So, even we "fix" the behavior of all bundled internal functions, we
> still can't claim that *all* functions throw an exception when called
> with too few or too many arguments in strict_types mode (besides that we
> easily might miss a few cases).  If the docs already make this claim,
> the docs should be fixed.
>
> Finally, I wonder why array_diff(), for instance, even has an explicit
> check for ZEND_NUM_ARGS() and for Z_TYPE() !=3D IS_ARRAY instead of
> properly invoking zend_parse_parameters() with "aa+" instead of "+" in
> the first place?  Maybe I'm missing something, but otherwise I would
> suggest to fix that altogether instead of piecemeal, even if that has to
> wait until 8.0.
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

Well, its behavior does differ with a single array: it will preserve
keys in this case. If more than one array is passed it will
numerically index the keys starting at zero. This is the only reason I
can think of.