Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95453
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.20 as permitted sender)
To: Davey Shafik <davey@php.net>
References: <CANaX5nfGzFsYue8J6yUpNnEYzgUTGj2g-BMWsw1cyahPH=fmmg@mail.gmail.com>
 <CAF+90c_30gzmMXKT0XhZDaTK277uV5edStfka2YVE2ia0xpK9Q@mail.gmail.com>
 <7cdd89c1-3fe5-3455-2f03-d5f6648d93d1@gmx.de>
 <CANaX5nfTifwbTmNYqZa2i728tCsWEOfadNeVBq5djNmK5fxPpw@mail.gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
Message-ID: <ca7d2c2b-fa2a-532e-b0e3-b188a1cd79ec@gmx.de>
Date: Fri, 26 Aug 2016 12:53:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CANaX5nfTifwbTmNYqZa2i728tCsWEOfadNeVBq5djNmK5fxPpw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 25.08.2016 at 18:37, Davey Shafik wrote:

> On Thu, Aug 25, 2016 at 8:12 PM, Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
> 
>> Indeed, the RFC explicitly claims:
>>
>> | Behavior of internal functions is not going to be changed.
> 
> This is correct for functions that had the correct behavior before
> (everything but array functions).
> 
> I can remove that part of the change — but if we're going to change it,
> doing in 7.1 rather than > 7.1 would be best.

AIUI, the actual implementation of the too_few_args RFC does what it
says, namely to not affect the behavior of internal function at all.
The issue you've raised is that we have introduced an inconsistency,
because some internal functions (e.g. array_diff) behave differently.

If that is so, reverting the too_few_args RFC is out of question,
because not changing the behavior of internal functions was intentional,
and I assume that everybody who voted on the RFC was aware of that.

The inconsistency between internal functions wrt. to too few/many
arguments in strict_types mode is not related to the too_few_args RFC at
all – we have this as of PHP 7.  Fixing this inconsistency as soon as
possible might be desirable, but it seems to me that is not even
possible in the general case, as not all relevant code is under our
control (think of PECL and even "private" extensions).

So, even we "fix" the behavior of all bundled internal functions, we
still can't claim that *all* functions throw an exception when called
with too few or too many arguments in strict_types mode (besides that we
easily might miss a few cases).  If the docs already make this claim,
the docs should be fixed.

Finally, I wonder why array_diff(), for instance, even has an explicit
check for ZEND_NUM_ARGS() and for Z_TYPE() != IS_ARRAY instead of
properly invoking zend_parse_parameters() with "aa+" instead of "+" in
the first place?  Maybe I'm missing something, but otherwise I would
suggest to fix that altogether instead of piecemeal, even if that has to
wait until 8.0.

-- 
Christoph M. Becker