Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95449
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.220.176 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <7cdd89c1-3fe5-3455-2f03-d5f6648d93d1@gmx.de>
References: <CANaX5nfGzFsYue8J6yUpNnEYzgUTGj2g-BMWsw1cyahPH=fmmg@mail.gmail.com>
 <CAF+90c_30gzmMXKT0XhZDaTK277uV5edStfka2YVE2ia0xpK9Q@mail.gmail.com> <7cdd89c1-3fe5-3455-2f03-d5f6648d93d1@gmx.de>
Date: Fri, 26 Aug 2016 00:37:15 +0800
Message-ID: <CANaX5nfTifwbTmNYqZa2i728tCsWEOfadNeVBq5djNmK5fxPpw@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c07778ab8328b053ae802a4
Subject: Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC
From: davey@php.net (Davey Shafik)

--94eb2c07778ab8328b053ae802a4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 25, 2016 at 8:12 PM, Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> On 24.08.2016 at 18:45, Nikita Popov wrote:
>
> > On Aug 24, 2016 9:55 AM, "Davey Shafik" <davey@php.net> wrote:
> >>
> >> Given this thread: http://externals.io/thread/233
> >>
> >> I'm not happy with the state of this going into RC1 next week, and
> without
> >> changes (such as the patch I provided), I would like to revert this
> change
> >> and leave it for 7.2.
> >>
> >> My patch will _retain_ BC for internal functions with non strict_types
> >> (except for the error message, which can be reconciled), and for
> functions
> >> that previously threw a TypeError, ArgumentCountError is a subclass so
> BC
> >> is preserved there also.
> >>
> >> The issue is that the array functions that do this argument count
> checking
> >> themselves and still issue a warning, regardless of strict_types.
> >>
> >> We can leave the original behavior for array functions, but they then
> >> differ from other internals functions.
> >>
> >> It is a BC break for userland functions (as per the RFC), throwing an
> >> ArgumentCountError regardless of strict_types.
> >>
> >> At this point, we _must_ come to consensus by Monday to get it into RC=
1
> > (if
> >> there are changes needed) or we should remove it from 7.1. Also, I wou=
ld
> >> like someone more experienced to review my patch.
> >
> > I have some trouble understanding what the issue is here. The mentioned
> RFC
> > affects only userland functions, so the non-standard behavior of some
> array
> > functions shouldn't matter.
> >
> > Personally I am entirely indifferent as to what exception gets thrown
> when
> > too little arguments are passed -- this is a type of error that should
> not
> > be caught by anything but catch-all handlers.
> >
> > Inability to provide a more specific exception should not be a blocker
> for
> > this, especially as this is beyond the scope of the original RFC.
>
> Indeed, the RFC explicitly claims:
>
> | Behavior of internal functions is not going to be changed.
>

This is correct for functions that had the correct behavior before
(everything but array functions).

I can remove that part of the change =E2=80=94 but if we're going to change=
 it,
doing in 7.1 rather than > 7.1 would be best.

- Davey

--94eb2c07778ab8328b053ae802a4--