Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95424 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 63686 invoked from network); 24 Aug 2016 07:54:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Aug 2016 07:54:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=me@daveyshafik.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=me@daveyshafik.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.220.170 cause and error) X-PHP-List-Original-Sender: me@daveyshafik.com X-Host-Fingerprint: 209.85.220.170 mail-qk0-f170.google.com Received: from [209.85.220.170] ([209.85.220.170:34371] helo=mail-qk0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/26-10212-FC25DB75 for ; Wed, 24 Aug 2016 03:54:56 -0400 Received: by mail-qk0-f170.google.com with SMTP id t7so7664246qkh.1 for ; Wed, 24 Aug 2016 00:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daveyshafik-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:from:date:message-id:subject:to; bh=ecms16SF5fzTgv+eAMNG2C0rlTY3J8Ho4dSmCCsjyJo=; b=f5LQfiyvKx1E2Vs4ZWPfdMYU3LG3PgDhVDVhlJa9dhAy9mZ4Tw28yVDD/ubCUfibp9 DEu8dvmOdLYUfuOoO6huiEAPv6GXXPj9+MuNhSvLNx2snQwqqVd/GkLtJlTbtF+y6Lx5 HSRKYS+Tgp2uH6MvRuuAhwyxagD52JcMAskpVtca7vvCkZeA1rVU7L0Gw3xBi41Kjiw4 PTbJs9iWHICQsNThmWTeT5Qna4XpD6yYZYHSqaLNyAwNxjrmn9eilKMB7FHlaNPnyZ4/ goNi0Yn9q/J9QtF90ksSF6wNgfeyjmG0QHYKU629ZItaXB38by0TTxlzvMObS/Q3yfJ+ an9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=ecms16SF5fzTgv+eAMNG2C0rlTY3J8Ho4dSmCCsjyJo=; b=lV2rzFAnHO3cp6pfIRuo0j0a5gZOkM1rY2RycQV6QraxjbzWdFCOF0hvbKHo53nURq 3GicOijzQWUs/OkXhp0y042WQ3W2QYFp8uu8CT1TUm7dVPseNAZKO3MzMNJAQkcJ8KA/ wIAWP7kjFyrX82l+if3imLCJje9Au81SVI9Cvf+jhOM9+I6IHRqKz5qrC1UePx/ZHlcY LRWZtx1aizkLa2zatkHHnh8zsFcxLHBvXO/awsOZE53zc1ZG1+wCC/iv3vDkfMQ9ocSF lEmyorPxSUSXfdqcsdjkBxYkGrwK4FPrHuLjEQWgYDzZpHd0SMlNW9VrA+QF7YbpADSI VXew== X-Gm-Message-State: AE9vXwPtEEq2CE1VgAgi0StLxWnxiT2Dfxa23k1VGaPd7mhPL5l1kxLoGWbHTqCL3x6sYrett9qwLaBYvaDXBg5V X-Received: by 10.55.92.193 with SMTP id q184mr1644934qkb.139.1472025293079; Wed, 24 Aug 2016 00:54:53 -0700 (PDT) MIME-Version: 1.0 Sender: me@daveyshafik.com Received: by 10.237.55.138 with HTTP; Wed, 24 Aug 2016 00:54:52 -0700 (PDT) Date: Wed, 24 Aug 2016 15:54:52 +0800 X-Google-Sender-Auth: IVXBGshtDIL11BybrpwwcFcG64A Message-ID: To: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a114e6328b1df4d053acc9807 Subject: Reverting "Too Few Arguments Exception" RFC From: davey@php.net (Davey Shafik) --001a114e6328b1df4d053acc9807 Content-Type: text/plain; charset=UTF-8 Hi all, Given this thread: http://externals.io/thread/233 I'm not happy with the state of this going into RC1 next week, and without changes (such as the patch I provided), I would like to revert this change and leave it for 7.2. My patch will _retain_ BC for internal functions with non strict_types (except for the error message, which can be reconciled), and for functions that previously threw a TypeError, ArgumentCountError is a subclass so BC is preserved there also. The issue is that the array functions that do this argument count checking themselves and still issue a warning, regardless of strict_types. We can leave the original behavior for array functions, but they then differ from other internals functions. It is a BC break for userland functions (as per the RFC), throwing an ArgumentCountError regardless of strict_types. At this point, we _must_ come to consensus by Monday to get it into RC1 (if there are changes needed) or we should remove it from 7.1. Also, I would like someone more experienced to review my patch. - Davey --001a114e6328b1df4d053acc9807--