Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95419 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20102 invoked from network); 23 Aug 2016 15:45:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Aug 2016 15:45:03 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error) X-PHP-List-Original-Sender: johannes@schlueters.de X-Host-Fingerprint: 217.114.215.10 mail.experimentalworks.net Received: from [217.114.215.10] ([217.114.215.10:38633] helo=mail.experimentalworks.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7E/D1-10212-B7F6CB75 for ; Tue, 23 Aug 2016 11:45:00 -0400 Received: by mail.experimentalworks.net (Postfix, from userid 1003) id 0EBCB4B1A5; Tue, 23 Aug 2016 17:45:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on km31408.keymachine.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.0 X-Spam-HAM-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [192.168.2.34] (ppp-46-244-184-85.dynamic.mnet-online.de [46.244.184.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: johannes@schlueters.de) by mail.experimentalworks.net (Postfix) with ESMTPSA id EAE1E4B1A4; Tue, 23 Aug 2016 17:44:58 +0200 (CEST) Message-ID: <1471967087.7303.20.camel@kuechenschabe> To: Kalle Sommer Nielsen Cc: Stanislav Malyshev , Pierre Joye , Christopher Jones , PHP Internals Date: Tue, 23 Aug 2016 17:44:47 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] orphan extensions cleanup From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Mon, 2016-08-15 at 10:17 +0200, Kalle Sommer Nielsen wrote: > readline > If removed, I guess this won't affect sapi/cli? It would. In 5.3 or so I moved the interactive shell to the readline extension (php -a) in order to help distributors who like to have extensions shared. I think "actual" readline functionality isn't used often in PHP, i.e. GitHub doesn't seem to have any relevant results except phpt files, syntax highlight descriptors etc. https://github.com/search?l=php&p=1&q=readline&type=Code&utf8=%E2%9C%93 If we remove the extension and move the shell part back into sapi/cli we have to teach distributors to link against readline or libedit and users won't have a way to "fix" this without recompiling complete PHP. I'm open for a discussion (probably in a different thread) about this. If needed I can do readline maintenance. > tokenizer > Like you mentioned, I think this should be kept in the core and > possibly maintained as a part of the parser. I do write some > development tools every now and then and make use of this amazing > extension and will only want it to be kept. The script to produce this is by me, if needed I can step in as official maintainer. A nice thing would be if we could get rid of the script and somehow generate this as part of the parser (which might mean making it part of the engine) ... johannes