Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.45 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAMUwpuTe_JE14pcXsMO=111OeAnzzN36WP8zrR0n7hyX0G3TyA@mail.gmail.com>
References: <CAEbg-4ZAMB=Em-nwCp++K3n59btaFSgW-yexhg3cbM3bQ1WjTg@mail.gmail.com>
 <CAMUwpuQe1bS1D9KVRKkqd7-jXw8sx_mWUDrxDjX=i9J5LQSnwg@mail.gmail.com>
 <dd455ef8-d02f-9e7f-94ba-8e276bce2688@gmx.de> <CAFMT4Noh_2BHDUETFtUppJi36m4vuYtmU1A2h_t-Swha1sxKdQ@mail.gmail.com>
 <031a2bf1-1996-1144-2b85-e10a40be9514@gmail.com> <CAFMT4Nrc7nXx4Q0qZzwUSw2LDsFwe9i9aVNTYOgjeFdhWjEtgg@mail.gmail.com>
 <7b81c830-1d05-a4ac-4713-1bb67cbec12c@gmx.de> <CAMUwpuSiLEToYCXzxQnhmtPXi=aO45vAhLWVi-3+U8+TOLYrVg@mail.gmail.com>
 <eb2a9f37-37ea-54fb-e094-fdb8629d159b@gmx.de> <CAEbg-4aWyaXTfs7xek_e3ND2wO5cR_5aEgZfMmT=3nBc2ACS8Q@mail.gmail.com>
 <CAMUwpuQaJVH9CadHarO1mdVMU2QN=UzLQ895GtKTJU4AEt0CYQ@mail.gmail.com>
 <CAEbg-4YxUxhHpDNmrpEZeQx1VgHPsbDm6xdPAeSzGwb-Sfnqng@mail.gmail.com>
 <CAMUwpuSH2yBggRy1ixTgZWA9CowqYXOt9zTPRaJKg3bEH34cZw@mail.gmail.com>
 <CAEbg-4bXZhAZvu90DbqguhxsgdnmJY9gD0vk0rBGWZjMDsXdrg@mail.gmail.com>
 <CAMUwpuSje=nEDOgk=cmNP7vLiRq01NwxyL28qaWeGmLf=LCpww@mail.gmail.com>
 <CAEbg-4Y3WupTfZ8jDs1vb_KTaaPcbrCDrnySJULDbxODvSz_Qw@mail.gmail.com>
 <CAFMT4Npa+aBtfa0d+xx2XGucaJJnFvomu3HvB9pAWK3xUjh3NQ@mail.gmail.com> <CAMUwpuTe_JE14pcXsMO=111OeAnzzN36WP8zrR0n7hyX0G3TyA@mail.gmail.com>
Date: Tue, 23 Aug 2016 08:58:37 -0600
Message-ID: <CAFMT4NrrVua7i+Ct-4gMxy0f5X=5EO3OD9RQRYVA2zNcp5s9ZQ@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: Alexander Lisachenko <lisachenko.it@gmail.com>, "Christoph M. Becker" <cmbecker69@gmx.de>, 
	Rowan Collins <rowan.collins@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects
 parameter1to be object, string given
From: levim@php.net (Levi Morrison)

On Tue, Aug 23, 2016 at 8:49 AM, Julien Pauli <jpauli@php.net> wrote:
> On Tue, Aug 23, 2016 at 4:13 PM, Levi Morrison <levim@php.net> wrote:
>> On Tue, Aug 23, 2016 at 7:56 AM, Alexander Lisachenko
>> <lisachenko.it@gmail.com> wrote:
>>>
>>> 2016-08-23 16:40 GMT+03:00 Julien Pauli <jpauli@php.net>:
>>>>
>>>> My patch allows that, but I can't find a use case to it.
>>>
>>>
>>>
>>> My use case for that was decorating of static methods with additional
>>> behaviour, so it's possible to cache the result of static methods, etc.
>>> Unfortunately, reflection API doesn't provide me such an ability, so I
>>> decided to switch to the combination of special closure with
>>> forward_static_call_array() and binding it to the desired scope.
>>>
>>>
>>> 2016-08-23 16:40 GMT+03:00 Julien Pauli <jpauli@php.net>:
>>>>
>>>> Try it.
>>>
>>>
>>> Yes, sure, I will check. However as I say earlier, now I use closure
>>> extraction and scope binding as more natural way to invoke such methods. So
>>> missing scope argument for static methods and ReflectionMethod->invoke() is
>>> a nice thing to have, but not a critical one.
>>
>> Seems to me you should be calling getClosure() and using
>> Closure::bindTo before invoking it. ReflectionMethod::invoke is really
>> just a short-cut for a common case; I don't think it's reasonable to
>> have it mirror the Closure API just to save one method call to get a
>> Closure.
>
> This cannot work.
> There is a special use case forbidding that.
> "Cannot rebind scope of closure created by
> ReflectionFunctionAbstract::getClosure()"
>
>
> Julien

I know this is a stability concern for internal classes but is there
anything really preventing this from user-land classes?