Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95405
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.46 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <CAEbg-4aWyaXTfs7xek_e3ND2wO5cR_5aEgZfMmT=3nBc2ACS8Q@mail.gmail.com>
References: <CAEbg-4ZAMB=Em-nwCp++K3n59btaFSgW-yexhg3cbM3bQ1WjTg@mail.gmail.com>
 <CAMUwpuQe1bS1D9KVRKkqd7-jXw8sx_mWUDrxDjX=i9J5LQSnwg@mail.gmail.com>
 <dd455ef8-d02f-9e7f-94ba-8e276bce2688@gmx.de> <CAFMT4Noh_2BHDUETFtUppJi36m4vuYtmU1A2h_t-Swha1sxKdQ@mail.gmail.com>
 <031a2bf1-1996-1144-2b85-e10a40be9514@gmail.com> <CAFMT4Nrc7nXx4Q0qZzwUSw2LDsFwe9i9aVNTYOgjeFdhWjEtgg@mail.gmail.com>
 <7b81c830-1d05-a4ac-4713-1bb67cbec12c@gmx.de> <CAMUwpuSiLEToYCXzxQnhmtPXi=aO45vAhLWVi-3+U8+TOLYrVg@mail.gmail.com>
 <eb2a9f37-37ea-54fb-e094-fdb8629d159b@gmx.de> <CAEbg-4aWyaXTfs7xek_e3ND2wO5cR_5aEgZfMmT=3nBc2ACS8Q@mail.gmail.com>
Date: Tue, 23 Aug 2016 15:01:57 +0200
Message-ID: <CAMUwpuQaJVH9CadHarO1mdVMU2QN=UzLQ895GtKTJU4AEt0CYQ@mail.gmail.com>
To: Alexander Lisachenko <lisachenko.it@gmail.com>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, Levi Morrison <levim@php.net>, 
	Rowan Collins <rowan.collins@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects
 parameter1to be object, string given
From: jpauli@php.net (Julien Pauli)

On Tue, Aug 23, 2016 at 2:56 PM, Alexander Lisachenko
<lisachenko.it@gmail.com> wrote:
>
> 2016-08-23 14:51 GMT+03:00 Christoph M. Becker <cmbecker69@gmx.de>:
>>
>> I suggest to deprecate all other types than NULL as first arg for static
>> methods, because passing an int, for instance, makes even less sense as
>> Rowan has already pointed out elsewhere in this thread.
>
>
>
> Alternative suggestion (vote for Julien's patch): use first argument as a
> string with LSB scope name, see my message from late 2013 year:
> http://markmail.org/message/ogeh33jedumgo5lx.
>
> I agree, that all other types don't make any sense. So my suggestion is
> following: for dynamic methods it should accept object or null. Null can
> mean that we want to unbind the method from the object and maybe call it
> like a closure? (just compare this with Closure::bindTo behaviour). For
> static methods this could be object (why not - it will be ignored), string
> (in this case it will be a scope name if we want to call parent method with
> preserving Late Static Binding) or just null (null will be equal to the
> string with object class name)
>
> Thoughts?
>

It makes no sense to change the scope of the method.
A method is not a closure.
A method is bound to a class , a closure is by default unbound.  A
method cannot be unbound. A method cannot change from one class to
another.

This :

class A { public static function foo() { } }
class B extends A { public static function foo() { }  }

$a = new reflectionMethod('A', 'foo');
$a->invoke('B');

would lead to the exact equivalent as this with my patch :
$b = new reflectionMethod('B', 'foo');
$b->invoke();


So I don't see why we should change and patch the code to support such
a strange use case ...
If you want to call B's foo , create a ReflectionMethod from B, not from A.



Julien