Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95391
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.217.181 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8U_y9=1uPtiWHeKkvXiQrO91fjd-cJoQB+wiy-zZJ_kw@mail.gmail.com>
References: <0668D584-EE51-4932-85D7-01D8BF70E409@trowski.com>
 <CADyq6s+qQEwXSqZUB6cs=zabfp28is57ZGK4nKb4TxivvhiZ8Q@mail.gmail.com>
 <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com> <CADyq6s+PEq9dtbKvv=7dWH6maePTwKTj9ki9W_25w4waC+orMw@mail.gmail.com>
 <D3DD20C1-9EF4-44EB-83E7-2DCB115C8057@trowski.com> <CADyq6s+sCY3UGACKXr-bJi8z_YNOOZwdMJuzDgA5M3VvJkyqHg@mail.gmail.com>
 <E4EE6269-8D50-4529-9A21-10B40D4D3B4A@trowski.com> <CADyq6sK22PQaji6pa727k6VS-pK6HzQhM5ccBORhC303_O7JgA@mail.gmail.com>
 <CADyq6s+_fS--RaO9zm4rxnLJt1EsCAY4evhn3SjAnyC0cT=-UQ@mail.gmail.com>
 <CADyq6sJve5XyRmubtyY6MeSsJYLFn2Y=W5a1kYy_7rAhH-Kn7g@mail.gmail.com>
 <EB599E31-B569-40DB-9E1C-1F9921AF687E@trowski.com> <CAFMT4NoACO4c_62nV8cc2gXfHdRH8JbmJm=XcANAV3CGhwij2w@mail.gmail.com>
 <CAFMT4NpJuXXtvbCFvxYfxq=fJncirO4b9_oBT46vTvrSLiJ-uA@mail.gmail.com>
 <CADyq6sJYJy_STaD30P0OJX_Fpa4abN1b8Qk4a_qvKfEq1C0tsQ@mail.gmail.com>
 <CAFMT4NoT3ee+5Vu4i7H886z9YDNe+51r0YpCoyOiV2iBwCN94A@mail.gmail.com>
 <CADyq6sLvDMra6jSobvr-Nu_VCXLzGqaMCV6V_Eg6r7-0phkQEg@mail.gmail.com>
 <CAFMT4NqVB_y4MMV709D6N5mkO=ZWwBYVGn5mmurqUvx3o7Jzdg@mail.gmail.com>
 <CADyq6sLyOtAXR1cAybi2nE4+NRPnji-s5MbOy9qEVafF=rVN9w@mail.gmail.com>
 <CA+kxMuRH0cvF1Vs5BTN2=mOmmNHPKiA_RuS+eogy_+YqxWTDWw@mail.gmail.com>
 <CADyq6sJMkzdZRBVfKuXXNDqw1B-rJKpR4tozT-58-LeOXxgwew@mail.gmail.com>
 <CA+kxMuQ-kBVAN7AfW+9MnBc5KbQKHkEy0zLxUJk364dtb+DZRA@mail.gmail.com> <CAF+90c8U_y9=1uPtiWHeKkvXiQrO91fjd-cJoQB+wiy-zZJ_kw@mail.gmail.com>
Date: Mon, 22 Aug 2016 21:56:03 +0100
Message-ID: <CA+kxMuTVdSbPjPgyPPynadOa2OYOtNbzLserThCtw2A2o1HORw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, Levi Morrison <levim@php.net>, 
	Aaron Piotrowski <aaron@trowski.com>, internals <internals@lists.php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names
From: danack@basereality.com (Dan Ackroyd)

On 22 August 2016 at 06:33, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> Hi.
>
> Now that we have made ReflectionType::__toString() be useless and not
> represent the type, this method should be deprecated in favor of using
> ReflectionNamedType::__toString(), ::allowsNull() and any further extensions
> that will be introduced later.
>

If we want to go that route, doesn't it make sense to:

* Leave ReflectionType::__toString() as it pre-7.1.0beta3 - i.e. not
including the ?nullable marker or the slash.

* Explain that ReflectionType::__toString() is a legacy function that
isn't nullable aware and that people should use the other functions to
get the full type information for anything that might contain
functions that have nullable parameters.

* Add a ReflectionType::isNullable() function so that can be reflected
properly, exactly as the user wrote them rather than an approximation.

Levi Morrison wrote:
> You must attempt to generate exactly what was written in user code

This is exactly why I don't think it's acceptable for the type
information to be including a question mark to indicate nullable.

I use reflection to take a function that has this signature:

function foo(Bar $sc = null) {...}

which is valid PHP 5.x and 7.0 code, and then generate a decorated
function like:

function loggingFoo(Bar $sc = null) {
   echo "before \n";
   foo($sc);
   echo "after \n";
}

If the type for the parameter suddenly starts having a ?nullable in
it, it means I can't run the code generator to produce code that can
be used on 5.x and 7.0 - even though the code being reflected on is
valid 5.x and 7.0 code.

We need to be able to generate exactly what was written in the user
code from Reflection, not just an equivalent form that only works on
7.1+

cheers
Dan
Ack