Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95385
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.21 as permitted sender)
To: Julien Pauli <jpauli@php.net>,
 Alexander Lisachenko <lisachenko.it@gmail.com>
References: <CAEbg-4ZAMB=Em-nwCp++K3n59btaFSgW-yexhg3cbM3bQ1WjTg@mail.gmail.com>
 <CAMUwpuQe1bS1D9KVRKkqd7-jXw8sx_mWUDrxDjX=i9J5LQSnwg@mail.gmail.com>
Cc: Rowan Collins <rowan.collins@gmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
Message-ID: <dd455ef8-d02f-9e7f-94ba-8e276bce2688@gmx.de>
Date: Mon, 22 Aug 2016 18:30:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAMUwpuQe1bS1D9KVRKkqd7-jXw8sx_mWUDrxDjX=i9J5LQSnwg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1
 to be object, string given
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 22.08.2016 at 18:00, Julien Pauli wrote:

> I agree this is a BC break and should not stay as-is in source code.

I wonder why we have more than 100 lines of "Backward incompatible
changes" in the PHP 7.1.0beta3 changelog[1], if BC breaks shouldn't be
introduced in a minor release.

> It makes some testsuites fail, that did not fail before ; thus it breaks things.

An estimated 10% (at least) of my *bugfixes* in GD broke at least one
PHPT, because the test was broken in the first place.

> I think @Alexander is right.
> We should allow passing a string, and perform some Late Static Binding
> through it.
> That would solve the BC Break problem as well as extend the feature in
> a more PHP-friendly way.

Are you sure that would solve the BC break?  As it were, one could pass
an arbitrary string.  I can easily imagine that some refactoring
introduced a new class in a hierarchy, but nobody noticed that an
::invoke() call would have to be adjusted accordingly.  Suddenly
changing the meaning of the first parameter may well introduce a
behavioral change.

[1] <https://github.com/php/php-src/blob/PHP-7.1.0beta3/UPGRADING#L18-L129>

-- 
Christoph M. Becker