Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95366
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.218.41 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <alpine.DEB.2.20.1608221059120.3780@whisky.home.derickrethans.nl>
References: <CANaX5nfdhKwau8jKBw1ABeLznyOeQ0iEAavwm+6izFevLBQRfg@mail.gmail.com>
 <alpine.DEB.2.20.1608221059120.3780@whisky.home.derickrethans.nl>
Date: Mon, 22 Aug 2016 18:11:11 +0800
Message-ID: <CANaX5neCwXie_qkjsVLhUPJdZyhbFHWNC5Yh-fUhpg2+bJzp9g@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=001a113d0188845542053aa6441f
Subject: Re: [PHP-DEV] Incorrect Argument Count Error
From: davey@php.net (Davey Shafik)

--001a113d0188845542053aa6441f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 22, 2016 at 5:59 PM, Derick Rethans <derick@php.net> wrote:

> On Fri, 19 Aug 2016, Davey Shafik wrote:
>
> > b) a huge BC break (stuff that currently throws a warning in
> > strict_types mode will now throw an exception, similar BC break as
> > we're implementing for userland functions regardless of strict_types)
>
> IMO, that's not acceptable at all between 7.0 and 7.1
>

So=E2=80=A6 option C?

Bear in mind, this _only_ affects people who have turned on strict_types,
and makes it consistent across the language. If we had implemented type
hints internally it would also have errored out in 7.0, but would be a
TypeError (which ArgumentCountError extends and therefore it's BC).

(FYI, we both voted against this RFC, and I'm not happy about it but trying
to at least make it not as bad :P)

- Davey

--001a113d0188845542053aa6441f--