Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95362
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+kxMuQ-kBVAN7AfW+9MnBc5KbQKHkEy0zLxUJk364dtb+DZRA@mail.gmail.com>
References: <0668D584-EE51-4932-85D7-01D8BF70E409@trowski.com>
 <CADyq6s+qQEwXSqZUB6cs=zabfp28is57ZGK4nKb4TxivvhiZ8Q@mail.gmail.com>
 <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com> <CADyq6s+PEq9dtbKvv=7dWH6maePTwKTj9ki9W_25w4waC+orMw@mail.gmail.com>
 <D3DD20C1-9EF4-44EB-83E7-2DCB115C8057@trowski.com> <CADyq6s+sCY3UGACKXr-bJi8z_YNOOZwdMJuzDgA5M3VvJkyqHg@mail.gmail.com>
 <E4EE6269-8D50-4529-9A21-10B40D4D3B4A@trowski.com> <CADyq6sK22PQaji6pa727k6VS-pK6HzQhM5ccBORhC303_O7JgA@mail.gmail.com>
 <CADyq6s+_fS--RaO9zm4rxnLJt1EsCAY4evhn3SjAnyC0cT=-UQ@mail.gmail.com>
 <CADyq6sJve5XyRmubtyY6MeSsJYLFn2Y=W5a1kYy_7rAhH-Kn7g@mail.gmail.com>
 <EB599E31-B569-40DB-9E1C-1F9921AF687E@trowski.com> <CAFMT4NoACO4c_62nV8cc2gXfHdRH8JbmJm=XcANAV3CGhwij2w@mail.gmail.com>
 <CAFMT4NpJuXXtvbCFvxYfxq=fJncirO4b9_oBT46vTvrSLiJ-uA@mail.gmail.com>
 <CADyq6sJYJy_STaD30P0OJX_Fpa4abN1b8Qk4a_qvKfEq1C0tsQ@mail.gmail.com>
 <CAFMT4NoT3ee+5Vu4i7H886z9YDNe+51r0YpCoyOiV2iBwCN94A@mail.gmail.com>
 <CADyq6sLvDMra6jSobvr-Nu_VCXLzGqaMCV6V_Eg6r7-0phkQEg@mail.gmail.com>
 <CAFMT4NqVB_y4MMV709D6N5mkO=ZWwBYVGn5mmurqUvx3o7Jzdg@mail.gmail.com>
 <CADyq6sLyOtAXR1cAybi2nE4+NRPnji-s5MbOy9qEVafF=rVN9w@mail.gmail.com>
 <CA+kxMuRH0cvF1Vs5BTN2=mOmmNHPKiA_RuS+eogy_+YqxWTDWw@mail.gmail.com>
 <CADyq6sJMkzdZRBVfKuXXNDqw1B-rJKpR4tozT-58-LeOXxgwew@mail.gmail.com> <CA+kxMuQ-kBVAN7AfW+9MnBc5KbQKHkEy0zLxUJk364dtb+DZRA@mail.gmail.com>
Date: Mon, 22 Aug 2016 07:33:20 +0200
Message-ID: <CAF+90c8U_y9=1uPtiWHeKkvXiQrO91fjd-cJoQB+wiy-zZJ_kw@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Cc: Marco Pivetta <ocramius@gmail.com>, Levi Morrison <levim@php.net>, 
	Aaron Piotrowski <aaron@trowski.com>, internals <internals@lists.php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=001a114dbd54d71307053aa262f8
Subject: Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names
From: nikita.ppv@gmail.com (Nikita Popov)

--001a114dbd54d71307053aa262f8
Content-Type: text/plain; charset=UTF-8

On Sun, Aug 21, 2016 at 10:28 PM, Dan Ackroyd <danack@basereality.com>
wrote:

> On 21 August 2016 at 20:43, Marco Pivetta <ocramius@gmail.com> wrote:
> >
> > Sadly, it won't. Here's an example that shows the BC break in a more
> > explicit way:
> >
> > function foo(Iterator $i = null) {}
> > var_dump((string) (new ReflectionParameter('foo', 0))->getType());
> >
> > This reports `Iterator` for PHP 7.0.x, `?\Iterator` for 7.1.x.
> > https://3v4l.org/tDkLj
>
>
> Thanks.
>
> I missed that part - I thought this was just about ?types, not things
> that have default of null.
>
> cheers
> Dan
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Hi.

Now that we have made ReflectionType::__toString() be useless and not
represent the type, this method should be deprecated in favor of using
ReflectionNamedType::__toString(), ::allowsNull() and any further
extensions that will be introduced later.

I recommend doing this swiftly so as to ensure that people do not use this
method on PHP 7.1 anymore and thus avoid pain on future upgrades.

Nikita

--001a114dbd54d71307053aa262f8--