Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95355
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.46 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CADyq6s+9PCy2=+T1uj8EtF1M4Z-52x3XR+7m2LKgH=rtyBEGzQ@mail.gmail.com>
References: <0668D584-EE51-4932-85D7-01D8BF70E409@trowski.com>
 <CADyq6s+qQEwXSqZUB6cs=zabfp28is57ZGK4nKb4TxivvhiZ8Q@mail.gmail.com>
 <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com> <CADyq6s+PEq9dtbKvv=7dWH6maePTwKTj9ki9W_25w4waC+orMw@mail.gmail.com>
 <D3DD20C1-9EF4-44EB-83E7-2DCB115C8057@trowski.com> <CADyq6s+sCY3UGACKXr-bJi8z_YNOOZwdMJuzDgA5M3VvJkyqHg@mail.gmail.com>
 <E4EE6269-8D50-4529-9A21-10B40D4D3B4A@trowski.com> <CADyq6sK22PQaji6pa727k6VS-pK6HzQhM5ccBORhC303_O7JgA@mail.gmail.com>
 <CADyq6s+_fS--RaO9zm4rxnLJt1EsCAY4evhn3SjAnyC0cT=-UQ@mail.gmail.com>
 <CADyq6sJve5XyRmubtyY6MeSsJYLFn2Y=W5a1kYy_7rAhH-Kn7g@mail.gmail.com>
 <EB599E31-B569-40DB-9E1C-1F9921AF687E@trowski.com> <CAFMT4NoACO4c_62nV8cc2gXfHdRH8JbmJm=XcANAV3CGhwij2w@mail.gmail.com>
 <CAFMT4NpJuXXtvbCFvxYfxq=fJncirO4b9_oBT46vTvrSLiJ-uA@mail.gmail.com>
 <CADyq6sJYJy_STaD30P0OJX_Fpa4abN1b8Qk4a_qvKfEq1C0tsQ@mail.gmail.com>
 <CAFMT4NoT3ee+5Vu4i7H886z9YDNe+51r0YpCoyOiV2iBwCN94A@mail.gmail.com>
 <CADyq6sLvDMra6jSobvr-Nu_VCXLzGqaMCV6V_Eg6r7-0phkQEg@mail.gmail.com>
 <CAFMT4NqVB_y4MMV709D6N5mkO=ZWwBYVGn5mmurqUvx3o7Jzdg@mail.gmail.com>
 <CADyq6sLyOtAXR1cAybi2nE4+NRPnji-s5MbOy9qEVafF=rVN9w@mail.gmail.com>
 <CA+kxMuRH0cvF1Vs5BTN2=mOmmNHPKiA_RuS+eogy_+YqxWTDWw@mail.gmail.com>
 <CADyq6sJMkzdZRBVfKuXXNDqw1B-rJKpR4tozT-58-LeOXxgwew@mail.gmail.com>
 <CAFMT4NrP+_3yOYbvJ585Kj1vwH5QqGM38WA8ZL9FD9y0BN=U9A@mail.gmail.com> <CADyq6s+9PCy2=+T1uj8EtF1M4Z-52x3XR+7m2LKgH=rtyBEGzQ@mail.gmail.com>
Date: Sun, 21 Aug 2016 14:20:29 -0600
Message-ID: <CAFMT4NrXjssZLf2Rn3mBKf+eW8dtfwEX5MJ0PeumhgHh8KWGUQ@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Dan Ackroyd <danack@basereality.com>, Aaron Piotrowski <aaron@trowski.com>, 
	internals <internals@lists.php.net>, Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=001a11367696c22e36053a9aa923
Subject: Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names
From: levim@php.net (Levi Morrison)

--001a11367696c22e36053a9aa923
Content-Type: text/plain; charset=UTF-8

On Sun, Aug 21, 2016 at 1:52 PM, Marco Pivetta <ocramius@gmail.com> wrote:

> I still want to see code that outweights these commonly used open-source
> tools before you grab that argument again.
>
> As also said by Dan: new features => adaptation required.
>
> Supporting `?` in your own home-grown internal code-generator is something
> you can do as part of a 7.1 migration path, exactly like we'll have to do
> with the OSS libs.
>
> That said, I'm muting the thread: I'm basically wasting time with this,
> apparently.
>
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
> On Sun, Aug 21, 2016 at 9:48 PM, Levi Morrison <levim@php.net> wrote:
>
>> The issue here is around changes that affect old features (__toString),
>>> where the behavior changes depending on whether a parameter is defaulted or
>>> not (also a previously existing feature)
>>>
>>
>> Which has existed for only one release. This is a small BC break and is
>> intended. We previously had nullable types just no way to really encode it
>> as a type. We now do. Breaking code for one single minor version is
>> perfectly acceptable, especially given that there are other codebases that
>> will break if we do not include the question mark.
>>
>>
>
There is a BC break either way. I do not understand why you cannot seem to
fully understand this. If there is a BC break either way why not stick with
intended behavior even if it breaks code for a few tools for a single
version of PHP?

--001a11367696c22e36053a9aa923--