Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95352
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+kxMuRH0cvF1Vs5BTN2=mOmmNHPKiA_RuS+eogy_+YqxWTDWw@mail.gmail.com>
References: <0668D584-EE51-4932-85D7-01D8BF70E409@trowski.com>
 <CADyq6s+qQEwXSqZUB6cs=zabfp28is57ZGK4nKb4TxivvhiZ8Q@mail.gmail.com>
 <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com> <CADyq6s+PEq9dtbKvv=7dWH6maePTwKTj9ki9W_25w4waC+orMw@mail.gmail.com>
 <D3DD20C1-9EF4-44EB-83E7-2DCB115C8057@trowski.com> <CADyq6s+sCY3UGACKXr-bJi8z_YNOOZwdMJuzDgA5M3VvJkyqHg@mail.gmail.com>
 <E4EE6269-8D50-4529-9A21-10B40D4D3B4A@trowski.com> <CADyq6sK22PQaji6pa727k6VS-pK6HzQhM5ccBORhC303_O7JgA@mail.gmail.com>
 <CADyq6s+_fS--RaO9zm4rxnLJt1EsCAY4evhn3SjAnyC0cT=-UQ@mail.gmail.com>
 <CADyq6sJve5XyRmubtyY6MeSsJYLFn2Y=W5a1kYy_7rAhH-Kn7g@mail.gmail.com>
 <EB599E31-B569-40DB-9E1C-1F9921AF687E@trowski.com> <CAFMT4NoACO4c_62nV8cc2gXfHdRH8JbmJm=XcANAV3CGhwij2w@mail.gmail.com>
 <CAFMT4NpJuXXtvbCFvxYfxq=fJncirO4b9_oBT46vTvrSLiJ-uA@mail.gmail.com>
 <CADyq6sJYJy_STaD30P0OJX_Fpa4abN1b8Qk4a_qvKfEq1C0tsQ@mail.gmail.com>
 <CAFMT4NoT3ee+5Vu4i7H886z9YDNe+51r0YpCoyOiV2iBwCN94A@mail.gmail.com>
 <CADyq6sLvDMra6jSobvr-Nu_VCXLzGqaMCV6V_Eg6r7-0phkQEg@mail.gmail.com>
 <CAFMT4NqVB_y4MMV709D6N5mkO=ZWwBYVGn5mmurqUvx3o7Jzdg@mail.gmail.com>
 <CADyq6sLyOtAXR1cAybi2nE4+NRPnji-s5MbOy9qEVafF=rVN9w@mail.gmail.com> <CA+kxMuRH0cvF1Vs5BTN2=mOmmNHPKiA_RuS+eogy_+YqxWTDWw@mail.gmail.com>
Date: Sun, 21 Aug 2016 21:43:25 +0200
Message-ID: <CADyq6sJMkzdZRBVfKuXXNDqw1B-rJKpR4tozT-58-LeOXxgwew@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Cc: Levi Morrison <levim@php.net>, Aaron Piotrowski <aaron@trowski.com>, 
	internals <internals@lists.php.net>, Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=047d7b87465e6319f9053a9a2645
Subject: Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names
From: ocramius@gmail.com (Marco Pivetta)

--047d7b87465e6319f9053a9a2645
Content-Type: text/plain; charset=UTF-8

Hi Dan,

On Sun, Aug 21, 2016 at 8:55 PM, Dan Ackroyd <danack@basereality.com> wrote:

> On 21 August 2016 at 17:01, Marco Pivetta <ocramius@gmail.com> wrote:
> > Yes, but the __toString API is used for codegen, and current code
> > generators don't expect a `?` to appear there.
>
> And they will continue to not have a `?` when reflecting PHP 7.0 code.
>

Sadly, it won't. Here's an example that shows the BC break in a more
explicit way:

function foo(Iterator $i = null) {}
var_dump((string) (new ReflectionParameter('foo', 0))->getType());

This reports `Iterator` for PHP 7.0.x, `?\Iterator` for 7.1.x.
https://3v4l.org/tDkLj


> It is only when reflecting 7.1 code, that has a different set of
> syntax, that the library will need to be changed to support a new
> version of PHP code.
>

Same as above. The problem is on existing code.


> This is exactly the same as userland PHP code parsers. They continue
> to work in new versions of PHP, but only when analysing code from
> versions they were written to support. They will need to be upgraded
> to be able to parse syntax that wasn't present in the version of PHP
> that they were initially written for.
>
> > How many ... failing unit tests does it take to explain a BC break?
>
> As nullable types are only introduced in PHP 7.1, I strongly suspect
> that you won't have any unit tests that would work on PHP 7.0 that
> will start failing on PHP 7.1.
>

> So the answer is 'more than zero' ?
>

The answer is "one that at least ran the frikken tests".


> We don't consider adding new features to be a BC break, as any code
> analyser or thing that uses reflection will continue to work, when
> they are given code from a version they were designed to support.
>

New features: OK. We all agree that `void` and `?Foo` need adaptations in
userland libs.

I wrote it before, and specifically wrote "New features => new
codegen/changes, this is normal/understood/accepted."

The issue here is around changes that affect old features (__toString),
where the behavior changes depending on whether a parameter is defaulted or
not (also a previously existing feature)

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--047d7b87465e6319f9053a9a2645--