Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95350
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NqVB_y4MMV709D6N5mkO=ZWwBYVGn5mmurqUvx3o7Jzdg@mail.gmail.com>
References: <0668D584-EE51-4932-85D7-01D8BF70E409@trowski.com>
 <CADyq6s+qQEwXSqZUB6cs=zabfp28is57ZGK4nKb4TxivvhiZ8Q@mail.gmail.com>
 <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com> <CADyq6s+PEq9dtbKvv=7dWH6maePTwKTj9ki9W_25w4waC+orMw@mail.gmail.com>
 <D3DD20C1-9EF4-44EB-83E7-2DCB115C8057@trowski.com> <CADyq6s+sCY3UGACKXr-bJi8z_YNOOZwdMJuzDgA5M3VvJkyqHg@mail.gmail.com>
 <E4EE6269-8D50-4529-9A21-10B40D4D3B4A@trowski.com> <CADyq6sK22PQaji6pa727k6VS-pK6HzQhM5ccBORhC303_O7JgA@mail.gmail.com>
 <CADyq6s+_fS--RaO9zm4rxnLJt1EsCAY4evhn3SjAnyC0cT=-UQ@mail.gmail.com>
 <CADyq6sJve5XyRmubtyY6MeSsJYLFn2Y=W5a1kYy_7rAhH-Kn7g@mail.gmail.com>
 <EB599E31-B569-40DB-9E1C-1F9921AF687E@trowski.com> <CAFMT4NoACO4c_62nV8cc2gXfHdRH8JbmJm=XcANAV3CGhwij2w@mail.gmail.com>
 <CAFMT4NpJuXXtvbCFvxYfxq=fJncirO4b9_oBT46vTvrSLiJ-uA@mail.gmail.com>
 <CADyq6sJYJy_STaD30P0OJX_Fpa4abN1b8Qk4a_qvKfEq1C0tsQ@mail.gmail.com>
 <CAFMT4NoT3ee+5Vu4i7H886z9YDNe+51r0YpCoyOiV2iBwCN94A@mail.gmail.com>
 <CADyq6sLvDMra6jSobvr-Nu_VCXLzGqaMCV6V_Eg6r7-0phkQEg@mail.gmail.com> <CAFMT4NqVB_y4MMV709D6N5mkO=ZWwBYVGn5mmurqUvx3o7Jzdg@mail.gmail.com>
Date: Sun, 21 Aug 2016 18:01:42 +0200
Message-ID: <CADyq6sLyOtAXR1cAybi2nE4+NRPnji-s5MbOy9qEVafF=rVN9w@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Aaron Piotrowski <aaron@trowski.com>, internals <internals@lists.php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=001a1146972271fa94053a970d3a
Subject: Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names
From: ocramius@gmail.com (Marco Pivetta)

--001a1146972271fa94053a970d3a
Content-Type: text/plain; charset=UTF-8

Yes, but the __toString API is used for codegen, and current code
generators don't expect a `?` to appear there.

How many engineers and failing unit tests does it take to explain a BC
break?

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On Sun, Aug 21, 2016 at 6:00 PM, Levi Morrison <levim@php.net> wrote:

> This is the ultimate point: if we don't prepend the question mark it will
>>> break code.
>>>
>>
>> This is the impedence here: `ReflectionType` is a *REFLECTION*, not a
>> code generator. Don't think of `ReflectionType#__toString()` as a way to
>> generate code: it is merely a string representation of the reflectoion.
>>
>
> This is the last I have to say on anything:
>
> You just proved the point. It's a *reflection* of what was written. If
> it's a nullable type then it needs a nullable reflection in the toString.
>

--001a1146972271fa94053a970d3a--