Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:95321 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48541 invoked from network); 19 Aug 2016 18:20:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Aug 2016 18:20:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=lauri.kentta@gmail.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=lauri.kentta@gmail.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain gmail.com does not designate 188.117.41.47 as permitted sender) X-PHP-List-Original-Sender: lauri.kentta@gmail.com X-Host-Fingerprint: 188.117.41.47 mailgateway.locotech.fi Linux 2.6 Received: from [188.117.41.47] ([188.117.41.47:44510] helo=mailgateway.locotech.fi) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FD/54-17996-7FD47B75 for ; Fri, 19 Aug 2016 14:20:39 -0400 Received: from localhost (mailgateway [127.0.0.1]) by mailgateway.locotech.fi (Postfix) with ESMTP id B007FA35A7D; Fri, 19 Aug 2016 21:20:35 +0300 (EEST) X-Virus-Scanned: amavisd-new at locotech.fi X-Spam-Flag: NO X-Spam-Score: -1.998 X-Spam-Level: X-Spam-Status: No, score=-1.998 tagged_above=-9998 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9] autolearn=no autolearn_force=no Received: from mailgateway.locotech.fi ([127.0.0.1]) by localhost (mailgateway.locotech.fi [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6JvVls4MQjf7; Fri, 19 Aug 2016 21:20:20 +0300 (EEST) Received: from posti.fimnet.fi (posti.fimnet.fi [172.16.1.44]) by mailgateway.locotech.fi (Postfix) with ESMTP id DDAC2A35A5F; Fri, 19 Aug 2016 21:20:19 +0300 (EEST) Received: from k-piste.dy.fi (unknown [172.16.1.39]) by posti.fimnet.fi (Postfix) with ESMTPSA id 95844100735; Fri, 19 Aug 2016 21:20:19 +0300 (EEST) Received: from localhost.localdomain ([::1] helo=k-piste.dy.fi) by k-piste.dy.fi with esmtp (Exim 4.87) (envelope-from ) id 1baoOx-0000mf-9X; Fri, 19 Aug 2016 21:20:19 +0300 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 19 Aug 2016 21:20:19 +0300 To: internals@lists.php.net Cc: Tom Worster In-Reply-To: References: <3d8be1faf8d4d3e5add3768d7a8eb16c@k-piste.dy.fi> <20160814211942.16358-1-lauri.kentta@gmail.com> Message-ID: <37f541c321ec5cae15d8ca0a1f9c0716@k-piste.dy.fi> X-Sender: lauri.kentta@gmail.com User-Agent: Roundcube Webmail/1.2.1 Subject: Re: [RFC: PATCH v1] Implement mt_srand_array From: lauri.kentta@gmail.com (=?UTF-8?Q?Lauri_Kentt=C3=A4?=) On 2016-08-15 18:53, Tom Worster wrote: > Hi Lauri, > > Do you have a PR against php-src on github? It's easier to read and > comment. > > Tom Here's a PR with a revised patch (also accepts other than pure integers): https://github.com/php/php-src/pull/2089 And here's an alternative with no sanity checks at all, which makes the patch even simpler (and more PHP-like, since 'foo' is silently converted to zero; this truly the most marvelous feature of PHP). https://github.com/Metabolix/php-src/tree/mt_srand_array-v3 -- Lauri Kenttä