Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95317
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.21 as permitted sender)
To: Davey Shafik <davey@php.net>
References: <ce120e4d-a166-e43d-bf36-e756a9241f8f@gmx.de>
 <036401d1f30f$afa85a40$0ef90ec0$@belski.net>
 <3dc2f23a-c4fb-a63d-ab7f-fa841091b313@gmx.de>
 <CANaX5ncTdzwVv1Uh6i_d-Yg8ahKOjkJfXBfgRB1-hK3AzatG-w@mail.gmail.com>
Cc: Anatol Belski <anatol.php@belski.net>,
 "internals@lists.php.net" <internals@lists.php.net>
Message-ID: <53037294-e8ed-31c8-95ef-522e02333e7c@gmx.de>
Date: Fri, 19 Aug 2016 17:35:31 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CANaX5ncTdzwVv1Uh6i_d-Yg8ahKOjkJfXBfgRB1-hK3AzatG-w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] SQLite 3.14
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Davey!

On 19.08.2016 at 15:32, Davey Shafik wrote:

> I saw this failure while packaging 7.1.0beta3, and assume it might be
> related to your update:
> 
> FAIL SQLite3 open_basedir checks
> [ext/sqlite3/tests/sqlite3_21_security.phpt]
> 
> ========DIFF========
> 006-
> 007- Warning: SQLite3::__construct(): open_basedir restriction in effect.
> File(%s) is not within the allowed path(s): (.) in
> %ssqlite3_21_security.php on line %d
> 008- Exception: open_basedir prohibits opening %s in
> %ssqlite3_21_security.php:%d
> 009- Stack trace:
> 010- #0 %ssqlite3_21_security.php(%d): SQLite3->__construct('%s')
> 011- #1 {main}
> ========DONE========
> 
> Can you please look into this in time for RC1?

I've just checked again with the tagged PHP-7.1.0beta3, but the test
succeeds on my machine.  Therefore it's hard for me to assess what is
wrong.  According to the diff, it appears that the second DB which
shouldn't be created according to the open_basedir restriction, is
actually successfully created.

Anyway, it's rather unlikely that an open_basedir related failure is
caused by updating SQLite, as this check is part of the PHP binding[1],
which has not been affected by this commit.  The issue might be caused
by commit cc125f27[2], but that's also somewhat unlikely, because the
Travis checks usually succeed generally.

Can you reproduce the test failure?  In which enviroment?

[1] <https://github.com/php/php-src/blob/PHP-7.1.0beta3/ext/sqlite3
/sqlite3.c#L125>
[2] <https://github.com/php/php-src/commit/cc125f27>

-- 
Christoph M. Becker