Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95312
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.47 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CANaX5nfdhKwau8jKBw1ABeLznyOeQ0iEAavwm+6izFevLBQRfg@mail.gmail.com>
References: <CANaX5nfdhKwau8jKBw1ABeLznyOeQ0iEAavwm+6izFevLBQRfg@mail.gmail.com>
Date: Fri, 19 Aug 2016 16:27:56 +0200
Message-ID: <CAJW__o2EEFcgcq5CxbL+1tw-x_9m-AqC+xKVT2ZzOZUuCtL6ug@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Incorrect Argument Count Error
From: kalle@php.net (Kalle Sommer Nielsen)

2016-08-19 15:05 GMT+02:00 Davey Shafik <davey@php.net>:
> Hey Internals,
>
> I'm working on the patch to change the error exception to
> \ArgumentCountError instead of \Error when too few, or too many arguments
> are passed in as discussed a couple of weeks ago.
>
> To be BC with 7.0, this extends \TypeError, which is the exception
> currently thrown when strict_types=1 for both userland and internal
> functions.
>
> I've run into an issue where things are inconsistent for internal functions.
>
> For example, the array_* functions, like array_diff, still have a warning
> thrown, regardless of strict_types:
>
> php_error_docref(NULL, E_WARNING, "at least %d parameters are required, %d
> given", req_args, ZEND_NUM_ARGS());

This seems more like an oversight than anything else, I guess cases
with variable argument count may have some similar parameter parsing
approaches. I think it should just be changed to the exception and to
respect strict_types. Despite it being a BC break, I don't think that
many will care to notice since its error handling for one and second
of all, we did do that for a lot of things in 7.0, and I would assume
that most of the userland developers expect us to continue converting
into exceptions where reasonable, so the programs will *hopefully*
quickly adapt.


-- 
regards,

Kalle Sommer Nielsen
kalle@php.net