Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95308
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.218.46 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
Date: Fri, 19 Aug 2016 23:05:19 +1000
Message-ID: <CANaX5nfdhKwau8jKBw1ABeLznyOeQ0iEAavwm+6izFevLBQRfg@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=94eb2c033cf2c462b0053a6c5954
Subject: Incorrect Argument Count Error
From: davey@php.net (Davey Shafik)

--94eb2c033cf2c462b0053a6c5954
Content-Type: text/plain; charset=UTF-8

Hey Internals,

I'm working on the patch to change the error exception to
\ArgumentCountError instead of \Error when too few, or too many arguments
are passed in as discussed a couple of weeks ago.

To be BC with 7.0, this extends \TypeError, which is the exception
currently thrown when strict_types=1 for both userland and internal
functions.

I've run into an issue where things are inconsistent for internal functions.

For example, the array_* functions, like array_diff, still have a warning
thrown, regardless of strict_types:

php_error_docref(NULL, E_WARNING, "at least %d parameters are required, %d
given", req_args, ZEND_NUM_ARGS());

It seems that fixing this will be:

a) a mammoth task

b) a huge BC break (stuff that currently throws a warning in strict_types
mode will now throw an exception, similar BC break as we're implementing
for userland functions regardless of strict_types)

c) something we should have done for 7.0, and that we cannot change now.

We are currently heading in 7.1.0RC1 in two weeks, and I want this issue
resolved in its entirety before then.

What say you, internals?

- Davey

--94eb2c033cf2c462b0053a6c5954--