Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95295
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.19 as permitted sender)
To: Kalle Sommer Nielsen <kalle@php.net>
References: <f790ef52-0a92-a8a3-bb3d-891713b390be@gmail.com>
 <CAJW__o0NAznPLP_DsZJYTPOmNsRQBn3qD+2G6niKboSEq_RxcA@mail.gmail.com>
 <da2b5256-5ba2-9375-f009-961e6e9f3dba@gmx.de>
 <CAJW__o3fGY5dE5EfBbvtFP2sCg0aeS8dXbpSkHO1bq2uzZ66dQ@mail.gmail.com>
Cc: Stanislav Malyshev <smalyshev@gmail.com>,
 PHP Internals <internals@lists.php.net>
Message-ID: <563adf64-081b-2dad-1533-d9b8f8bf8a12@gmx.de>
Date: Thu, 18 Aug 2016 15:46:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAJW__o3fGY5dE5EfBbvtFP2sCg0aeS8dXbpSkHO1bq2uzZ66dQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] orphan extensions cleanup
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Kalle!

On 18.08.2016 at 15:12, Kalle Sommer Nielsen wrote:

> 2016-08-18 15:03 GMT+02:00 Christoph M. Becker <cmbecker69@gmx.de>:
>
>> I don't know, but most certainly not on Windows.  I had a look at
>> ext/dba, because I like that we have it bundled, but got 3 failing tests
>> (flatfile and inifile), which might be caused by running in a Vagrant
>> box on NTFS.  So I tried to compile on Windows, just to learn that
>> config.w32 is totally out-dated.  It doesn't support individual config
>> options for the different drivers, but rather checks whether db3 is
>> found, and only then configures the built in drivers.  Of course, db3 is
>> not part of the delivered deps, what is likely the reason that
>> dba_php.dll isn't distributed anymore as of PHP 5.3 (it would make
>> sense, IMO, to ship dba_php.dll with the built-in drivers plus those
>> whose requirements could be bundled in the deps).
> 
> Hmm interesting, I can try take a look once I'm at home again.
> Extensions that can support more features in newer versions and such
> are usually not checked on Windows, as unlike m4 files we do not
> compile check for symbols and such and assume a certain version as
> minimum, but with the low targeted audience we have that builds PHP on
> their on, this is not an issue. We do have win32/libs.txt I think that
> lists the libs we use for distro builds.

You probably mean win32/build/libs_version.txt (I wasn't aware of this
file; thanks!).  AFAICS, none of the external dba drivers are already
there, and the DB 3-5 binaries can't probably be added due to legal issues.

> But I will have to look at our deps and see if it is possible to get
> this running again with some cross reference to the m4.

That would be great!  A quick fix (simply removing the db3 check) made
it compile, but the test suite stalled on dba_flatfile.phpt.
Apparantly, there are issues regarding mode 'n' on Windows/NTFS.

> As for zend_get_parameters_array_ex() usage, this should be a no
> brainer quick fix.

Indeed.  I've noted that only, because it shows that the extension is
not actively maintained (otherwise the maintainer would almost certainly
have noticed the deprecation warning and fixed it right away).

-- 
Christoph M. Becker