Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95294
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.66 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <da2b5256-5ba2-9375-f009-961e6e9f3dba@gmx.de>
References: <f790ef52-0a92-a8a3-bb3d-891713b390be@gmail.com>
 <CAJW__o0NAznPLP_DsZJYTPOmNsRQBn3qD+2G6niKboSEq_RxcA@mail.gmail.com> <da2b5256-5ba2-9375-f009-961e6e9f3dba@gmx.de>
Date: Thu, 18 Aug 2016 15:12:05 +0200
Message-ID: <CAJW__o3fGY5dE5EfBbvtFP2sCg0aeS8dXbpSkHO1bq2uzZ66dQ@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] orphan extensions cleanup
From: kalle@php.net (Kalle Sommer Nielsen)

Hi

2016-08-18 15:03 GMT+02:00 Christoph M. Becker <cmbecker69@gmx.de>:
> I don't know, but most certainly not on Windows.  I had a look at
> ext/dba, because I like that we have it bundled, but got 3 failing tests
> (flatfile and inifile), which might be caused by running in a Vagrant
> box on NTFS.  So I tried to compile on Windows, just to learn that
> config.w32 is totally out-dated.  It doesn't support individual config
> options for the different drivers, but rather checks whether db3 is
> found, and only then configures the built in drivers.  Of course, db3 is
> not part of the delivered deps, what is likely the reason that
> dba_php.dll isn't distributed anymore as of PHP 5.3 (it would make
> sense, IMO, to ship dba_php.dll with the built-in drivers plus those
> whose requirements could be bundled in the deps).
>
> Fixing config.w32 shouldn't be too hard (it may take quite some time to
> test with the different drivers, though), but I expect further issues
> would have to be solved.  Besides some unresolved bugs[1], for instance,
> it still uses zend_get_parameters_array_ex() at least once[2], even
> though this API has been deprecated as of PHP 7.0.0.

Hmm interesting, I can try take a look once I'm at home again.
Extensions that can support more features in newer versions and such
are usually not checked on Windows, as unlike m4 files we do not
compile check for symbols and such and assume a certain version as
minimum, but with the low targeted audience we have that builds PHP on
their on, this is not an issue. We do have win32/libs.txt I think that
lists the libs we use for distro builds.

But I will have to look at our deps and see if it is possible to get
this running again with some cross reference to the m4.

As for zend_get_parameters_array_ex() usage, this should be a no
brainer quick fix.


> [1]
> <https://bugs.php.net/search.php?cmd=display&package_name[]=DBM%2FDBA+related>
> [2] <https://github.com/php/php-src/blob/PHP-7.0.9/ext/dba/dba.c#L654>


-- 
regards,

Kalle Sommer Nielsen
kalle@php.net