Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95266
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com>
References: <0668D584-EE51-4932-85D7-01D8BF70E409@trowski.com>
 <CADyq6s+qQEwXSqZUB6cs=zabfp28is57ZGK4nKb4TxivvhiZ8Q@mail.gmail.com> <15E198DD-FF66-475D-ABBC-54ECD2B6BF62@trowski.com>
Date: Wed, 17 Aug 2016 18:45:49 +0200
Message-ID: <CADyq6s+PEq9dtbKvv=7dWH6maePTwKTj9ki9W_25w4waC+orMw@mail.gmail.com>
To: Aaron Piotrowski <aaron@trowski.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb709d4d22aef053a47332d
Subject: Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names
From: ocramius@gmail.com (Marco Pivetta)

--047d7bb709d4d22aef053a47332d
Content-Type: text/plain; charset=UTF-8

Since scalar types are invalid anyway if prepended with `\`, I see no point
in producing a string with the `\` in it.

The current consumers of `Type` assume no `\` is prepended, and we spent an
age and a half dealing with `\` being in front of class names in doctrine
(and finally got rid of it).

This is not being really helpful, as it is.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On Wed, Aug 17, 2016 at 6:44 PM, Aaron Piotrowski <aaron@trowski.com> wrote:

> Marco,
>
> > On Aug 17, 2016, at 11:22 AM, Marco Pivetta <ocramius@gmail.com <mailto:
> ocramius@gmail.com>> wrote:
> >
> > Sorry, I have to object here: this is quite a BC break for Zend\Code,
> specifically. We will have to re-adjust the code generators to adapt to the
> newly introduced prepended `\`.
> >
> > In addition to that, there is no need for `\` to be prepended to a type
> string, since inside string scope, we are always dealing with the base
> namespace.
> >
> > Seems unnecessary and causes a lot of headaches, instead of actually
> simplifying things.
> >
> > Marco Pivetta
> >
> > http://twitter.com/Ocramius <http://twitter.com/Ocramius>
> >
> > http://ocramius.github.com/ <http://ocramius.github.com/>
> >
>
>
> Adjustments will be necessary in Zend\Code no matter what because of
> nullable types. If a type is nullable, ReflectionType::__toString() will
> return "?\Type\Name" or without the changes I committed it would return
> "?Type\Name".
>
> If you need the type name without the leading ? or \, use
> ReflectionNamedType::getName().
>
> It would be nice to have no BC breaks, but right now I'm not seeing a way
> of handling nullable types in ReflectionType::__toString() without some
> sort of BC break.
>
> Aaron Piotrowski
>
>

--047d7bb709d4d22aef053a47332d--