Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95230
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.216.175 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <CANaX5ncfb8ohU4tt_udyXtpr7L5rYwbiiob3Fp=qos22QmWaUw@mail.gmail.com>
References: <CANaX5ncVr5idYUtVtgjEYxRwjabi3f6Bg1-cKtoGvym=Ck1PLA@mail.gmail.com>
 <CAF+90c_HvAEr_0-DZMzT2DjqugaugJ55sj99epDEeU7QHV+=rA@mail.gmail.com>
 <CANaX5ne04WmezRSgrLw9PDcEHzQa_0A-E01nNH00rRqD6KYsog@mail.gmail.com>
 <CANUQDCgHjaJeWNZiK4D=ry7u4O9DSCTte5tEkCy5kBFJy7F=3Q@mail.gmail.com>
 <DUB129-W477A507C9661007E58D731F9190@phx.gbl> <CANaX5ncfb8ohU4tt_udyXtpr7L5rYwbiiob3Fp=qos22QmWaUw@mail.gmail.com>
Date: Tue, 16 Aug 2016 23:44:51 +1000
Message-ID: <CANaX5ndy9LnMrD4NPp-3_uSRVKMQZos0n1LL+v75pp=3y0DQVw@mail.gmail.com>
To: Thomas Punt <tpunt@hotmail.co.uk>
Cc: Niklas Keller <me@kelunik.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=94eb2c0671ee98b641053a308dab
Subject: Re: [PHP-DEV] Change to Too Few Args Exception RFC
From: davey@php.net (Davey Shafik)

--94eb2c0671ee98b641053a308dab
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hey all,

Can we please reach a resolution on this?

- Davey

On Sun, Aug 7, 2016 at 9:04 AM, Davey Shafik <davey@php.net> wrote:

> AFAICT, to make this change, I'd have to modify:
>
> ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool
> throw_exception, const char *format, ...) /* {{{ */
>
> To be:
>
> ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool
> throw_exception, zend_class_entry *zend_error, const char *format, =E2=80=
=A6) /*
> {{{ */
>
> Which=E2=80=A6 would be a BC break for extensions perhaps?
>
> There is also zend_type_error, I'm not sure how that relates, I don't
> think it gets used in this case. Or, I could add zend_(internal_?)argumen=
t_count_error
> and use that instead.
>
> Thoughts?
>
> - Davey
>
>
> On Sat, Aug 6, 2016 at 4:10 AM, Thomas Punt <tpunt@hotmail.co.uk> wrote:
>
>> Hi!
>>
>> > From: me@kelunik.com
>> >
>> > I don't like "ArgumentError", how about "WrongArgumentCountError"? May=
be
>> > also "WrongArgumentsError".
>>
>> I'd favour simply ArgumentCountError. No need to prepend a "wrong" to th=
e
>> error class name - we can already guess it's wrong because it has
>> resulted in
>> an error :)
>>
>> -Tom
>>
>
>

--94eb2c0671ee98b641053a308dab--