Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95212
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c_4S7XyhhJ1C8iRjGFxnHUMrfNHMUni+0rBOBwKQHg2_g@mail.gmail.com>
References: <7716d180-2365-efc9-e9b3-9fe0998e273b@fleshgrinder.com>
 <CAF+90c_F_YgpsCkfAqZdj2VzeiUGRqUmmguGhHkf-9Tdrvt5Sg@mail.gmail.com>
 <c8fa44b6-c7e9-c4ae-ce03-474c96ead2f6@gmail.com> <CAF+90c_4S7XyhhJ1C8iRjGFxnHUMrfNHMUni+0rBOBwKQHg2_g@mail.gmail.com>
Date: Mon, 15 Aug 2016 23:17:02 +0200
Message-ID: <CAF+90c8p06F-Xf5n2KKYtzeGy5UBELwOfW+-rfsBTS4kzKZGYA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114dbd54de6443053a22c058
Subject: Re: [PHP-DEV] [RFC] [Vote] var_info
From: nikita.ppv@gmail.com (Nikita Popov)

--001a114dbd54de6443053a22c058
Content-Type: text/plain; charset=UTF-8

On Fri, Jul 22, 2016 at 10:21 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Sat, Jul 9, 2016 at 12:19 AM, Stanislav Malyshev <smalyshev@gmail.com>
> wrote:
>
>> Hi!
>>
>> > Lastly, I'll just leave this list of type-related improvements I'd
>> actually
>> > like to see:
>> >  * Make is_object() return true for IncompleteClass. This is just
>> > ridiculous. I care zero about the theoretical BC impact.
>>
>> I have no idea why it doesn't do so. I'll try to dig up when it was made
>> so and see if there's some explanation.
>>
>> >  * Make gettype() return 'resource (unknown type)'  instead of just
>> > 'unknown type' for closed resources. This makes the output clear while
>> > still leaving the closed resource distinction.
>>
>> That makes total sense. And BC impact is rather minimal given that
>> closed resources are useless.
>>
>
> I've created PRs for both of these:
>
> gettype() on closed resources: https://github.com/php/php-src/pull/2022
> is_object() on Incomplete_Class: https://github.com/php/php-src/pull/2023
>
> Unless there are objections from core devs I'll apply both in a few days.
>
> Nikita
>

As there were no objections, I've now merged both changes:

https://github.com/php/php-src/commit/34824b70f8e72b200d77957145bb61883b03322d
https://github.com/php/php-src/commit/89f63779711f34d87c2464ae13965df868d6231f

As I forgot to handle this earlier, I went with master-only.

Nikita

--001a114dbd54de6443053a22c058--