Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95156
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.18 as permitted sender)
To: Dan Ackroyd <danack@basereality.com>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <CA+kxMuSgm_45x-VbmSpKdOdJbPC6WrcH=7Ut8ZWHOceNC5-XsA@mail.gmail.com>
Message-ID: <0d1e3cfc-f5df-474d-f8dc-c806bec0e412@gmx.de>
Date: Mon, 15 Aug 2016 01:34:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CA+kxMuSgm_45x-VbmSpKdOdJbPC6WrcH=7Ut8ZWHOceNC5-XsA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [RFC] get_class() disallow null parameter
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 14.08.2016 at 13:00, Dan Ackroyd wrote:

> Following an earlier discussion in January, here is a small RFC to
> change get_class() to disallow null being passed as parameter.
> 
> https://wiki.php.net/rfc/get_class_disallow_null_parameter
> 
> Allowing null to be passed to get_class() is a 'gotcha' that is almost
> always a mistake in someone's code.
> 
> By preventing null being passed, get_class() will be far more likely
> to do what people think it should do, and so result in fewer bugs in
> code.
> 
> This RFC is a small change and so is appropriate for a point release.
> Other ways of making this function behave as people expect it to are
> not as small changes, and are probably not appropriate for point
> releases.

Prohibiting `get_class(NULL)` is certainly a good idea, but I have some
concerns regarding BC.  While `__CLASS__` has been introduced with PHP
4.3.0, it had the glitch to return the lower-cased class name before PHP
5.0.0.  So there *might* still be PHP 5 code around using `get_class(NULL)`.

The deprecation might be more appropriate, and could equally well catch
an inadvertent `get_class(NULL)`.

-- 
Christoph M. Becker