Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95148
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.19 as permitted sender)
To: Stanislav Malyshev <smalyshev@gmail.com>, Nikita Popov <nikic@php.net>
References: <85e38ba1-58d4-f8a7-33d4-5f4aa7fce44d@gmx.de>
 <19a35995-a032-3413-cade-919d60d33875@gmail.com>
Cc: internals@lists.php.net
Message-ID: <8e6deefe-4419-4592-04fd-b8e39f154228@gmx.de>
Date: Sun, 14 Aug 2016 23:32:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <19a35995-a032-3413-cade-919d60d33875@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Bug #72828
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi!

On 14.08.2016 at 10:21, Stanislav Malyshev wrote:

>> You have commented on <https://bugs.php.net/bug.php?id=72828>:
>>
>> | Unless the allocations explicitly use the system allocator (i.e. do
>> | not use emalloc and variants), do NOT introduce NULL checks.
>>
>> Can you please elaborate, why that shouldn't be done.
>>
>> Actually, the allocations use safe_emalloc() and emalloc(),
>> respectively[1].  However, the only client of the function does
> 
> These do not need null checks. If e* functions can't alloc memory, they
> produce fatal error, bail out and do not return. So if it returned, it
> succeeded. The only reason why it can return null is a bug. In this case
> we'd prefer it crashing fast - bugs in memory allocator are hard to
> find, and closer to the source the crash is, easier it to catch it.
> 
> If pe* or system functions are used, then check may be warranted.

Thanks!

I had already closed the bug report, because the issue affects only PHP
5.6, and I don't think this extraneous NULL check is a real bug.  Please
re-open if you don't agree, in which case I'll remove the NULL check.

-- 
Christoph M. Becker