Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95120
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain wkhudgins.info from 23.83.218.22 cause and error)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Date: Sat, 13 Aug 2016 12:47:03 -0400
To: Simon Welsh <simon@simon.geek.nz>
Cc: internals@lists.php.net
In-Reply-To: <EECABEB0-D1E5-4438-A061-477C9BEDC024@simon.geek.nz>
References: <8442f1fa5544b2ca03e7cebbc64e8e5c@wkhudgins.info>
 <EECABEB0-D1E5-4438-A061-477C9BEDC024@simon.geek.nz>
Message-ID: <eab667bf34e12ee2ad8b6bedabf66cc2@wkhudgins.info>
User-Agent: Roundcube Webmail/1.1.4
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC Posted for str_begins and str_ends functions
From: will@wkhudgins.info

On 2016-08-13 04:34, Simon Welsh wrote:
>> On 2/08/2016, at 8:52 AM, will@wkhudgins.info wrote:
>>=20
>> Hello,
>>=20
>> I recently emailed the group about submitting an RFC for str_begins()=20
>> and str_ends() functions. The RFC has now been officially submitted=20
>> and is viewable at:
>>=20
>> https://wiki.php.net/rfc/add_str_begin_and_end_functions
>>=20
>> The github PR may be found at:
>>=20
>> https://github.com/php/php-src/pull/2049
>>=20
>> Hope to be hearing about this,
>>=20
>> Will
>=20
> Firstly, the argument ordering is the wrong way round for a string
> function. String functions =E2=80=94 especially search-related ones =E2=
=80=94 are
> haystack, needle (see strpos, strstr, strcspn, strpbrk, etc).
>=20
> Secondly, I feel like this RFC does need to include that it=E2=80=99s a=
 BC
> break by introducing new global functions. A quick search shows that
> SugarCRM[1] already implements str_begin and str_end functions and
> there=E2=80=99s likely to be other projects that do too.
>=20
> [1]:
> https://github.com/sugarcrm/sugarcrm_dev/blob/ae189cfa4ed4edd6a4e1e0d9d=
1d5ec66f46a0b74/include/utils.php#L2082-L2090
> --
> Simon Welsh

You are correct, functions like strpos and strstr do follow (haystack,=20
needle) but functions like str_replace follow the format (needle,=20
haystack). Because I did these functions with the underscore, it made=20
sense to make the functions follow the format found in other str_*=20
functions. If the functions were changed to be strbegin, stribegin,=20
strend, and striend, then it would make sense to follow the (haystack,=20
needle) format. However, I think adding the underscore greatly improves=20
the readability of these functions. And if the functions are named with=20
an underscore, I think it should follow the format found in the other=20
underscore functions.

Good call on the BC break, I had not thought about it breaking userland=20
functions with the same name.

-Will