Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95113
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.19 as permitted sender)
To: Nikita Popov <nikic@php.net>
Cc: internals@lists.php.net
Message-ID: <85e38ba1-58d4-f8a7-33d4-5f4aa7fce44d@gmx.de>
Date: Sat, 13 Aug 2016 14:42:02 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Bug #72828
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Nikita!

You have commented on <https://bugs.php.net/bug.php?id=72828>:

| Unless the allocations explicitly use the system allocator (i.e. do
| not use emalloc and variants), do NOT introduce NULL checks.

Can you please elaborate, why that shouldn't be done.

Actually, the allocations use safe_emalloc() and emalloc(),
respectively[1].  However, the only client of the function does
explicitly check for a NULL return[2], which can only happen, if
safe_emalloc() fails.  So if no NULL checks should be done, this one
should be removed as well.

[1]
<https://github.com/php/php-src/blob/php-5.6.24/ext/standard/string.c#L2926-L2927>
[2]
<https://github.com/php/php-src/blob/php-5.6.24/ext/standard/string.c#L3133-L3134>

-- 
Christoph M. Becker