Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95103
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.50 as permitted sender)
MIME-Version: 1.0
Reply-To: bishop@php.net
Sender: bishop.bettini@gmail.com
In-Reply-To: <CAGa2bXbocMsoa3fMRSJCUAE-mAEu9uX0oZa3LnVYi-AS9qoXBA@mail.gmail.com>
References: <CAGa2bXbocMsoa3fMRSJCUAE-mAEu9uX0oZa3LnVYi-AS9qoXBA@mail.gmail.com>
Date: Fri, 12 Aug 2016 15:49:37 -0400
Message-ID: <CAEYWF=4aXrdMCbkzNQV6m=HJzgRN65FERy3kgMB4MnRtXxfWAA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113d522e883d570539e530c8
Subject: Re: [PHP-DEV] [RFC][VOTE] Add session_gc() function
From: bishop@php.net (Bishop Bettini)

--001a113d522e883d570539e530c8
Content-Type: text/plain; charset=UTF-8

On Wed, Aug 10, 2016 at 5:30 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> This RFC is to add session_gc() function.
>
> session_gc() function is required API for periodic session GC that is
> best practice for production web sites.
>
> https://wiki.php.net/rfc/session-gc
> It requires 2/3 majority to pass.
> Vote starts: 2016/08/10  - Vote ends: 2016/08/17 23:59:59 UTC
>

+1.

Should we document a polyfill, since the session GC firing logic can be
non-intuitive? Here's an attempt, anyhow:

function session_gc() {
    $initial = [
        session_status(),
        ini_get('session.gc_probability'),
        ini_get('session.gc_divisor'),
    ];
    if (PHP_SESSION_DISABLED === $initial[0]) {
        return false;
    }
    if (PHP_SESSION_ACTIVE === $initial[0]) {
        session_write_close();
    }
    ini_set('session.gc_probability', 1);
    ini_set('session.gc_divisor',     1);
    session_start();
    ini_set('session.gc_probability', $initial[1]);
    ini_set('session.gc_divisor',     $initial[2]);
    if (PHP_SESSION_NONE === $initial[0]) {
        session_write_close();
    }
    return true;
}

--001a113d522e883d570539e530c8--