Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:95030
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender)
MIME-Version: 1.0
References: <CAPwsocH7t6XQaN8p-q3pMj4v55VTh15k5RoT5LUKFb9TeucrPg@mail.gmail.com>
 <069eeb79-5fa7-0c52-515c-8be836d6fce2@thefsb.org>
In-Reply-To: <069eeb79-5fa7-0c52-515c-8be836d6fce2@thefsb.org>
Date: Wed, 10 Aug 2016 22:44:45 +0000
Message-ID: <CAPwsocGwpieN2nP0ibbPWGoqaSc0EoChaKqfqFwDQppu32qejQ@mail.gmail.com>
To: Tom Worster <fsb@thefsb.org>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=001a1140232202df820539bf66c0
Subject: Re: BC break with rand() where min > max
From: leight@gmail.com (Leigh)

--001a1140232202df820539bf66c0
Content-Type: text/plain; charset=UTF-8

On Wed, 10 Aug 2016 at 14:19 Tom Worster <fsb@thefsb.org> wrote:

> Your fix seems fine for rand() but less so for mt_rand().
>
> Applying this fix will break much less mt_rand()-using code than not
> applying it will break rand()-using code. From that point of view,
> applying it is the better choice.
>
> Otoh, it's like copy-pasting a weird old bug from rand() to mt_rand().
> The plan was to make rand() alias mt_rand(). Now I'm not sure that's a
> smart plan.
>
> Tom
>

I've pushed a fix that keeps the old behaviour for both

I've un-aliased rand from mt_rand, added a min > max check to rand, and
then call the common code with parameters reversed if necessary.

--001a1140232202df820539bf66c0--