Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:9496 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79043 invoked by uid 1010); 23 Apr 2004 13:57:28 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 79008 invoked from network); 23 Apr 2004 13:57:27 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 23 Apr 2004 13:57:27 -0000 Received: (qmail 7897 invoked from network); 23 Apr 2004 13:57:26 -0000 Received: from localhost (HELO AndiNotebook.zend.com) (127.0.0.1) by localhost with SMTP; 23 Apr 2004 13:57:26 -0000 Message-ID: <5.1.0.14.2.20040423165710.034fb208@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Fri, 23 Apr 2004 16:57:23 +0300 To: "Rob Richards" , "Sterling Hughes" Cc: ,"Paul Querna" In-Reply-To: <048b01c42896$fa6efe40$f7dea8c0@cyberware.local> References: <1082583400.12577.19.camel@powah.cc.force-elite.com> <1CA1D9B6-93F7-11D8-9EC0-000A95E073A0@php.net> <1082596603.15932.5.camel@powah.cc.force-elite.com> <020a01c42862$9fcec210$f7dea8c0@cyberware.local> <06E7C5C7-947C-11D8-9086-000A95E073A0@php.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] xmlSetGenericErrorFunc Abuse From: andi@zend.com (Andi Gutmans) At 02:23 PM 4/22/2004 -0400, Rob Richards wrote: >From: Sterling Hughes > > > I think you are off base in removing them. We need them to hook into > > PHP's error handling system. I think setting/resetting in RINIT > > instead of MINIT is a good place to start and see if that fixes the > > problem. I personally could care less about the threaded case (i hope > > PHP stops using this TSRM stuff and just recommends FastCGI), although > > someone here who cares more may have opinions about that. I guess we > > could add an #ifdef TSRM to the system, and not set the generic error > > handler - if someone cares enough about the threaddites. > >Sterling, > >You're actually correct, go figure ;). I was backwards in the thread calls >for libxml. Putting into RINIT/SHUTDOWN works correctly for both the treaded >and non threaded systems (the current placement is what would cause problems >for threaded servers). > >Andi, is it okay to commit this change right now? Yes, please do. Thanks, Andi