Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94959
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.220.180 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <CAPwsocH7t6XQaN8p-q3pMj4v55VTh15k5RoT5LUKFb9TeucrPg@mail.gmail.com>
References: <CAPwsocH7t6XQaN8p-q3pMj4v55VTh15k5RoT5LUKFb9TeucrPg@mail.gmail.com>
Date: Mon, 8 Aug 2016 15:12:14 -0700
Message-ID: <CANaX5ndGfjzGeGFmd_vi9WRJC6LUqXUj5LUPwFDtU6yNe8yZRg@mail.gmail.com>
To: Leigh <leight@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0603b265d872053996b53b
Subject: Re: [PHP-DEV] BC break with rand() where min > max
From: davey@php.net (Davey Shafik)

--94eb2c0603b265d872053996b53b
Content-Type: text/plain; charset=UTF-8

Leigh,

I would _very_ much prefer to keep this BC. If we do the right thing, and
there are no repercussions, I'd actually remove the warning. If you think
we might want to disallow this in the future, use an E_DEPRECATED, but a
warning seems pointless unless it's doing the wrong thing, or it's going to
start doing the wrong thing at some point.

- Davey

On Mon, Aug 8, 2016 at 2:36 PM, Leigh <leight@gmail.com> wrote:

> Hi all,
>
> There has been an unforeseen break with rand() when the minimum value is
> greater than the maximum.
>
> Prior to 7.1 rand() would happily accept backwards parameters and return a
> value, however in the 7.1 branch it now emits a warning and returns false.
>
> I've preemptively committed a fix to allow min > max and return a value as
> in previous versions, but have kept the warning.
>
> Looking for some feedback/opinions on whether anyone else thinks this
> should be fixed differently (or not at all).
>
> N.B. this also changes the behaviour of mt_rand to now accept min > max
>

--94eb2c0603b265d872053996b53b--