Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94910
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.163 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXaGQrYFsiULwBA3mMLH-61LuLSwwu9KZiqy799a4VwJjA@mail.gmail.com>
References: <CAGa2bXa8Oj=xi6ZUKYFe5XXuhZvOL6JT=31QHoq8EG-9veGDBg@mail.gmail.com>
 <nnu4fj$cul$1@blaine.gmane.org> <CAGa2bXZrtf1jy_W4Dzs72mxs9kmXx5586jbagjHRop3uzcuFYA@mail.gmail.com>
 <nnv8rf$24e$1@blaine.gmane.org> <CAGa2bXZh1BP48oM+AHzB9Yb4r5+B+W8WDOU-KEsVe+N4KHza4g@mail.gmail.com>
 <CAEZPtU5UAc7d++kjPa3YFUN6w=p=73tyHrG8WGLfsJXXMWg2Gw@mail.gmail.com> <CAGa2bXaGQrYFsiULwBA3mMLH-61LuLSwwu9KZiqy799a4VwJjA@mail.gmail.com>
Date: Mon, 8 Aug 2016 09:24:26 +0200
Message-ID: <CANUQDCgM1k6DrkQ11Z7uZu2t-Y83maoHOfrk4TeM7ju_PDe32A@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Pierre Joye <pierre.php@gmail.com>, PHP internals <internals@lists.php.net>, 
	Christian Stadler <stadli@gmx.de>
Content-Type: multipart/alternative; boundary=047d7b874df4693e0105398a4ef2
Subject: Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() to
 which version?
From: me@kelunik.com (Niklas Keller)

--047d7b874df4693e0105398a4ef2
Content-Type: text/plain; charset=UTF-8

2016-08-08 0:20 GMT+02:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:

> Hi Pierre, Niklas
>
> On Sun, Aug 7, 2016 at 9:20 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> > I would not rush it into 7.1.
> On Mon, Aug 8, 2016 at 12:20 AM, Niklas Keller <me@kelunik.com> wrote:
> > Isn't it a bit late to target 7.1 anyway?
>
> I feel the same way indeed. However, it does not change existing
> feature at all, but this is a pure addition. It's one of the largest
> mandatory piece that PHP is missing. It's good for 7.1.0, IMO.
> (Another largest piece is escaping API for basic needs. e.g.
> we don't even have JavaScript string escape API.)
>
> I made choices for targeted version,  7.1.0 or 7.2.0
>

Feature freeze has been beta1. If the RM says it's too late, we don't need
a vote. It's too late.

Regards, Niklas


> https://wiki.php.net/rfc/add_validate_functions_to_filter
>
> If this RFC is passed for 7.2.0, then we can adjust the feature until
> its release.
>
>
> > But anything proposed is already possible very easily in userland.
>
> This part is debatable. To implement feature that provides
> filter_require_*() and validation filter behavior with them, users
> have to write many lines of code. Some features are hard to implement
> in user code such as INT/OCTAL/HEX overflow detection.
>
>
> > I see them as conditions flow not errors per se but flow.
> > Invalid options could raise exceptions but it brings inconsistencies
> with the other filter functions.
>
> I really think we should have Exception handling standard in
> CODING_STANDARD, too.
> This issue could be handled by PHP 8.0 or PHP 7.2.
>
> > I feel like this rfc needs more discussions and maybe we will add more
> things to filter as well.
>
> Validation filters with new functions are made to work conservative
> way. So it would not be a issue relaxing them later.
>
> Use of exception is issue. IMO, it would be more useful if there is
> filter validation exception object that has more details in it. i.e.
> Offensive input key, data, filter name and filter options, remove
> filter_get_invalid_key(). I may add the new exception,
> FilterValidateException. (I choose "Validate" here, since most
> exceptions will be raised by validation filters)
>
> In fact, I don't like the way exception works currently. I'll add
> mentioned FilterValidateException before vote. Does this make you feel
> better?
>
> I feel the feature is fully implemented if I add FilterValidateException.
>
> Regards,
>
> P.S. There is conflicting pressures on RFC. I need to minimize changes
> so that reviewer can understand the RFC easily, but I would like to
> implement feature fully. Some changes cannot add/work well
> individually. This exception issue is one of them, another is
> https://wiki.php.net/rfc/precise_session_management  It includes
> mandatory feature for proper/secure session management and implements
> all possible features that would be required. Yet, it is declined :(
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--047d7b874df4693e0105398a4ef2--