Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:9490
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <048b01c42896$fa6efe40$f7dea8c0@cyberware.local>
To: "Andi Gutmans" <andi@zend.com>, "Sterling Hughes" <sterling@php.net>
Cc: <internals@lists.php.net>, "Paul Querna" <chip@force-elite.com>
References: <1082583400.12577.19.camel@powah.cc.force-elite.com> <1CA1D9B6-93F7-11D8-9EC0-000A95E073A0@php.net> <1082596603.15932.5.camel@powah.cc.force-elite.com> <D39D5842-941A-11D8-9EC0-000A95E073A0@php.net> <020a01c42862$9fcec210$f7dea8c0@cyberware.local> <06E7C5C7-947C-11D8-9086-000A95E073A0@php.net>
Date: Thu, 22 Apr 2004 14:23:57 -0400
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] xmlSetGenericErrorFunc Abuse
From: rrichards@ctindustries.net ("Rob Richards")

From: Sterling Hughes

> I think you are off base in removing them.  We need them to hook into
> PHP's error handling system.  I think setting/resetting in RINIT
> instead of MINIT is a good place to start and see if that fixes the
> problem.   I personally could care less about the threaded case (i hope
> PHP stops using this TSRM stuff and just recommends FastCGI), although
> someone here who cares more may have opinions about that. I guess we
> could add an #ifdef TSRM to the system, and not set the generic error
> handler - if someone cares enough about the threaddites.

Sterling,

You're actually correct, go figure ;). I was backwards in the thread calls
for libxml. Putting into RINIT/SHUTDOWN works correctly for both the treaded
and non threaded systems (the current placement is what would cause problems
for threaded servers).

Andi, is it okay to commit this change right now?

Rob