Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94879
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.219 cause and error)
MIME-Version: 1.0
In-Reply-To: <CANaX5ne04WmezRSgrLw9PDcEHzQa_0A-E01nNH00rRqD6KYsog@mail.gmail.com>
References: <CANaX5ncVr5idYUtVtgjEYxRwjabi3f6Bg1-cKtoGvym=Ck1PLA@mail.gmail.com>
 <CAF+90c_HvAEr_0-DZMzT2DjqugaugJ55sj99epDEeU7QHV+=rA@mail.gmail.com> <CANaX5ne04WmezRSgrLw9PDcEHzQa_0A-E01nNH00rRqD6KYsog@mail.gmail.com>
Date: Sat, 6 Aug 2016 12:44:41 +0200
Message-ID: <CANUQDCgHjaJeWNZiK4D=ry7u4O9DSCTte5tEkCy5kBFJy7F=3Q@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=001a11435ee2dc9fee053964de2f
Subject: Re: [PHP-DEV] Change to Too Few Args Exception RFC
From: me@kelunik.com (Niklas Keller)

--001a11435ee2dc9fee053964de2f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2016-08-06 11:53 GMT+02:00 Davey Shafik <davey@php.net>:

> On Sat, Aug 6, 2016 at 2:34 AM, Nikita Popov <nikita.ppv@gmail.com> wrote=
:
>
> > On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik <davey@php.net> wrote:
> >
> >> Hey all,
> >>
> >> I know this is a little late in the process, but it's something I've
> >> noticed while prepping some content around 7.1.
> >>
> >> This RFC: https://wiki.php.net/rfc/too_few_args
> >>
> >> Passed, and has been implemented, but I feel that throwing an `\Error`
> >> exception is a mistake. I think we should another more concrete
> exception
> >> class for this error:
> >>
> >> `\TooFewArgumentsError extends \Error`
> >>
> >> A use case where this may trivially occur is where you are using
> argument
> >> unpacking and the unpacked array is too small. Writing this, just look=
s
> >> bad:
> >>
> >> try {
> >>    foo(=E2=80=A6 $args);
> >> } catch (\Error $e) { }
> >>
> >> compared:
> >>
> >> try {
> >>    foo(=E2=80=A6 $args);
> >> } catch (\TooFewArgumentsError $e) { }
> >>
> >> Thoughts? Dmitry?
> >>
> >> Given the tiny change this is, and that is backwards compatible with t=
he
> >> original RFC, I would like to add this to 7.1 for beta3.
> >>
> >> I think I can make this change myself.
> >>
> >> - Davey
> >>
> >
> > Problem: We already use TypeError for this for internal functions. If w=
e
> > want to introduce an extra exception for this, lets use it for internal
> > functions as well. In that case we should probably go with something th=
at
> > applies not just to too few arguments, but also to too many.
> >
>
> Are you saying that in PHP 7.0, if you call an internal function with too
> few, or too many arguments it will emit a TypeError exception?
>
> Can you provide examples? It's obviously not every function, e.g. fopen()
> emits a Warning if you forget the second arg.
>
> With that in mind, to make this BC, TooFewArguments would have to extend
> TypeError which isn't great.  Maybe, "ArgumentError" and the message will
> make it clear if it's too few or too many?
>
> - Davey
>

I don't like "ArgumentError", how about "WrongArgumentCountError"? Maybe
also "WrongArgumentsError".

Regards, Niklas

--001a11435ee2dc9fee053964de2f--