Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94877
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CANaX5ncVr5idYUtVtgjEYxRwjabi3f6Bg1-cKtoGvym=Ck1PLA@mail.gmail.com>
References: <CANaX5ncVr5idYUtVtgjEYxRwjabi3f6Bg1-cKtoGvym=Ck1PLA@mail.gmail.com>
Date: Sat, 6 Aug 2016 11:34:00 +0200
Message-ID: <CAF+90c_HvAEr_0-DZMzT2DjqugaugJ55sj99epDEeU7QHV+=rA@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>
Content-Type: multipart/alternative; boundary=94eb2c0957740a60a6053963e229
Subject: Re: [PHP-DEV] Change to Too Few Args Exception RFC
From: nikita.ppv@gmail.com (Nikita Popov)

--94eb2c0957740a60a6053963e229
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik <davey@php.net> wrote:

> Hey all,
>
> I know this is a little late in the process, but it's something I've
> noticed while prepping some content around 7.1.
>
> This RFC: https://wiki.php.net/rfc/too_few_args
>
> Passed, and has been implemented, but I feel that throwing an `\Error`
> exception is a mistake. I think we should another more concrete exception
> class for this error:
>
> `\TooFewArgumentsError extends \Error`
>
> A use case where this may trivially occur is where you are using argument
> unpacking and the unpacked array is too small. Writing this, just looks
> bad:
>
> try {
>    foo(=E2=80=A6 $args);
> } catch (\Error $e) { }
>
> compared:
>
> try {
>    foo(=E2=80=A6 $args);
> } catch (\TooFewArgumentsError $e) { }
>
> Thoughts? Dmitry?
>
> Given the tiny change this is, and that is backwards compatible with the
> original RFC, I would like to add this to 7.1 for beta3.
>
> I think I can make this change myself.
>
> - Davey
>

Problem: We already use TypeError for this for internal functions. If we
want to introduce an extra exception for this, lets use it for internal
functions as well. In that case we should probably go with something that
applies not just to too few arguments, but also to too many.

Nikita

--94eb2c0957740a60a6053963e229--