Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94875
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.217.171 cause and error)
MIME-Version: 1.0
In-Reply-To: <01e3ed40-cf40-4a0e-aa03-0e4326257d7c@email.android.com>
References: <01e3ed40-cf40-4a0e-aa03-0e4326257d7c@email.android.com>
Date: Sat, 6 Aug 2016 08:33:05 +0100
Message-ID: <CAL=_i_mGYo0j=foMH4dxs-LjefzaZmom7eCumOPveBzTPvCCow@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: "davey@php.net" <davey@php.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c1911daa8f6ff053962312a
Subject: Re: [PHP-DEV] Re: Change to Too Few Args Exception RFC
From: pthreads@pthreads.org (Joe Watkins)

--94eb2c1911daa8f6ff053962312a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Morning all,

   Good idea, +1 for just doing it ...

Cheers
Joe

On Sat, Aug 6, 2016 at 8:18 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> I don't see a big problem accepting this. The change is really minor, and
> makes sense.
>
> Dmitry.
>
> On Aug 6, 2016 5:26 AM, Davey Shafik <davey@php.net> wrote:
> Hey all,
>
> I know this is a little late in the process, but it's something I've
> noticed while prepping some content around 7.1.
>
> This RFC: https://wiki.php.net/rfc/too_few_args
>
> Passed, and has been implemented, but I feel that throwing an `\Error`
> exception is a mistake. I think we should another more concrete exception
> class for this error:
>
> `\TooFewArgumentsError extends \Error`
>
> A use case where this may trivially occur is where you are using argument
> unpacking and the unpacked array is too small. Writing this, just looks b=
ad:
>
> try {
>    foo(=E2=80=A6 $args);
> } catch (\Error $e) { }
>
> compared:
>
> try {
>    foo(=E2=80=A6 $args);
> } catch (\TooFewArgumentsError $e) { }
>
> Thoughts? Dmitry?
>
> Given the tiny change this is, and that is backwards compatible with the
> original RFC, I would like to add this to 7.1 for beta3.
>
> I think I can make this change myself.
>
> - Davey
>
>
>
>

--94eb2c1911daa8f6ff053962312a--