Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94836
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
To: internals@lists.php.net
References: <CAGa2bXa8Oj=xi6ZUKYFe5XXuhZvOL6JT=31QHoq8EG-9veGDBg@mail.gmail.com>
 <nnu4fj$cul$1@blaine.gmane.org>
 <CAGa2bXZrtf1jy_W4Dzs72mxs9kmXx5586jbagjHRop3uzcuFYA@mail.gmail.com>
 <nnv8rf$24e$1@blaine.gmane.org>
 <CAGa2bXZh1BP48oM+AHzB9Yb4r5+B+W8WDOU-KEsVe+N4KHza4g@mail.gmail.com>
Message-ID: <27c5add4-2c4c-bab1-6ca7-9c191917dd0e@gmail.com>
Date: Thu, 4 Aug 2016 22:04:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZh1BP48oM+AHzB9Yb4r5+B+W8WDOU-KEsVe+N4KHza4g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() to
 which version?
From: rowan.collins@gmail.com (Rowan Collins)

Hi Yasuo,

On 04/08/2016 20:29, Yasuo Ohgaki wrote:
> One of my objective is following best practices.
> Prefer exception over error is one of them. Although, I strongly suggest
> to use exception for validation errors, I will have choices.

Best practice is to use exceptions to indicate an error *inside* the 
function, i.e. something going wrong with the function itself. If I run 
(as a simplified example) validate_var('abc', FILTER_NUMERIC) that's not 
something going wrong inside validate_var(), so validate_var() shouldn't 
be throwing an exception, IMO.

Now, the *reason* I'm calling validate_var may be that the function I'm 
writing will go wrong if the validation doesn't pass, but that's up to 
*me* to throw an exception:

if ( validate_var($foo, FILTER_NUMERIC) ) {
     throw new InvalidArgumentException;
}

That said, in another message you explained that this isn't intended for 
"validation" in the sense of "form validation", but in a more restricted 
sense of "dangerous data"; I think the name misled me, and may mislead 
others, if that is the sole purpose of the function. I'm still not 
entirely convinced, though, that a boolean-returning function wouldn't 
be enough to fill both purposes.

Regards,

-- 
Rowan Collins
[IMSoP]