Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94817 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48858 invoked from network); 3 Aug 2016 21:14:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Aug 2016 21:14:22 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:36801] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CC/A0-42458-BAE52A75 for ; Wed, 03 Aug 2016 17:14:21 -0400 Received: (qmail 24537 invoked by uid 89); 3 Aug 2016 21:14:15 -0000 Received: from unknown (HELO mail-qk0-f169.google.com) (yohgaki@ohgaki.net@209.85.220.169) by 0 with ESMTPA; 3 Aug 2016 21:14:15 -0000 Received: by mail-qk0-f169.google.com with SMTP id p186so89605923qkd.1 for ; Wed, 03 Aug 2016 14:14:15 -0700 (PDT) X-Gm-Message-State: AEkoouu6LfzAS+aGkgfrjLD2+fYayAGoCsCQeSzgTbxnqn6mMNmgeJqNhYOQA5rMhvc66l5n84dGuaQqdxB/ZA== X-Received: by 10.233.232.195 with SMTP id a186mr2335814qkg.18.1470258839671; Wed, 03 Aug 2016 14:13:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.85.242 with HTTP; Wed, 3 Aug 2016 14:13:19 -0700 (PDT) In-Reply-To: References: Date: Thu, 4 Aug 2016 06:13:19 +0900 X-Gmail-Original-Message-ID: Message-ID: To: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [RFC][DISCUSSION] Add validation functions to filter From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi all, Patch for this RFC is update https://github.com/php/php-src/pull/2048 - Added filter_check_definition() - Check definition array for validate_*_array() and filter_*_array(). These functions ignores error silently and this behavior could result in serious security issue. We should provide this function at least. - Made to require filter definitions for validate_() functions. RFC is updated accordingly. https://wiki.php.net/rfc/add_validate_functions_to_filter There is suggestion to use "CTRL". I used CNTRL for control char, since POSIX iscntrl() exists. We have ctype_cntrl(), IntlChar::iscntrl() If shorter constant name is preferred, I don't mind at all. FILTER_FLAG_STRING_ALLOW_CNTRL =E2=86=93 FILTER_FLAG_STRING_ALLOW_CTRL Any comments? Regard, -- Yasuo Ohgaki yohgaki@ohgaki.net