Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94806
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEsg9X1j0zAnGjstebQRgkWvAEsxER7QAQeH-ne9UMP8QOLboQ@mail.gmail.com>
References: <8442f1fa5544b2ca03e7cebbc64e8e5c@wkhudgins.info>
 <CAESVnVpAzMzZ9uXUVAQcPT-mQ5hj0EvQPij1TE5OEg5f_iF6kA@mail.gmail.com>
 <CAGa2bXZssvAhFJB4QzWj_m1Du65StU2OYGu=1kaNKPxvjwOe8w@mail.gmail.com> <CAEsg9X1j0zAnGjstebQRgkWvAEsxER7QAQeH-ne9UMP8QOLboQ@mail.gmail.com>
Date: Wed, 3 Aug 2016 07:44:29 +0900
Message-ID: <CAGa2bXbZ=TcbFrt=6hxmMstJSQj63vcED6vxANkHSjXWaLzymg@mail.gmail.com>
To: David Rodrigues <david.proweb@gmail.com>
Cc: Sara Golemon <pollita@php.net>, will@wkhudgins.info, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] RFC Posted for str_begins and str_ends functions
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi David,

On Tue, Aug 2, 2016 at 10:36 AM, David Rodrigues <david.proweb@gmail.com> wrote:
> Sara Golemon wrote:
>> Feeling "meh" on it (neither for nor against), but I would consider
>> consistency with other str*() functions by making case-insensitivity
>> live in separate functions rather than as a parameter. e.g.
>> str_begins(), str_ibegins(), str_ends(), end_iends()
>
> I guess that "i" isn't appliable when it have slashes.
> In this case, functions should be: strbegins, stribegins, strends, striends.
> In all case, I think that is better a third parameter and keep underlined.

This is difficult issue.
String function names are inconsistent currently.
It is better to stick to CODING_STANDARDS naming convention for new
function names. Therefore, new string functions are better to be named
str_*() unless they are too strange.

e.g.
http://php.net/manual/en/function.str-replace.php
http://php.net/manual/en/function.str-ireplace.php

I would like to fix function name inconsistencies by having aliases in
near future.
https://wiki.php.net/rfc/consistent_function_names

It might be okay  to have "s" in function names, but if we want to be
consistent,

str_replace -> str_replaces
str_ireplace -> str_ireplaces

IMO, following names are better for consistency.

str_begin
str_ibegin
str_end
str_iend

In addition, str_replace() has seach_value at first, so signature might be

boolean str_begin(string $search_value, string $str, [boolean
$case_sensitive = true])
boolean str_end(string $search_value, string $str, string
$search_value [boolean $case_sensitive = true])

However, strstr() (and other str functions without "_". e.g.
strpos/stripos/strrpos/strripos) has search_value as the 2nd
parameter. If we follow this format, current signature is fine.

It may be better sort out and fix consistency issues first, then add
new functions. Otherwise, we may introduce more consistency issues.

Regards,

BTW, having "i" is more readable.

str_ibegin("searchthis", $str);
is more readable than
str_begin("seachthis", $str, TRUE);
as programmer does not have to know that's the TRUE means.
It's small thing, but small things add up.

--
Yasuo Ohgaki
yohgaki@ohgaki.net