Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94792
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZssvAhFJB4QzWj_m1Du65StU2OYGu=1kaNKPxvjwOe8w@mail.gmail.com>
References: <8442f1fa5544b2ca03e7cebbc64e8e5c@wkhudgins.info>
 <CAESVnVpAzMzZ9uXUVAQcPT-mQ5hj0EvQPij1TE5OEg5f_iF6kA@mail.gmail.com> <CAGa2bXZssvAhFJB4QzWj_m1Du65StU2OYGu=1kaNKPxvjwOe8w@mail.gmail.com>
Date: Mon, 1 Aug 2016 22:36:33 -0300
Message-ID: <CAEsg9X1j0zAnGjstebQRgkWvAEsxER7QAQeH-ne9UMP8QOLboQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Sara Golemon <pollita@php.net>, will@wkhudgins.info, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] RFC Posted for str_begins and str_ends functions
From: david.proweb@gmail.com (David Rodrigues)

Sara Golemon wrote:
> Feeling "meh" on it (neither for nor against), but I would consider
> consistency with other str*() functions by making case-insensitivity
> live in separate functions rather than as a parameter. e.g.
> str_begins(), str_ibegins(), str_ends(), end_iends()

I guess that "i" isn't appliable when it have slashes.
In this case, functions should be: strbegins, stribegins, strends, striends.
In all case, I think that is better a third parameter and keep underlined.



Yasuo Ohgaki wrote:
> +1 for having functions for case insensitivity.
> I'm not sure if we should have "s". i.e. str_begin"s".

I think that "s" is good here.
Sounds better for me, but I don't know if it is right in english.
In JS, for instance, we have startsWith. It have a "s" too.

2016-08-01 21:06 GMT-03:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:
> On Tue, Aug 2, 2016 at 7:56 AM, Sara Golemon <pollita@php.net> wrote:
>> On Mon, Aug 1, 2016 at 3:52 PM,  <will@wkhudgins.info> wrote:
>>> I recently emailed the group about submitting an RFC for str_begins() and
>>> str_ends() functions. The RFC has now been officially submitted and is
>>> viewable at:
>>>
>>> https://wiki.php.net/rfc/add_str_begin_and_end_functions
>>>
>> Feeling "meh" on it (neither for nor against), but I would consider
>> consistency with other str*() functions by making case-insensitivity
>> live in separate functions rather than as a parameter. e.g.
>> str_begins(), str_ibegins(), str_ends(), end_iends()
>
> +1 for having functions for case insensitivity.
> I'm not sure if we should have "s". i.e. str_begin"s".
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



-- 
David Rodrigues