Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94748 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38805 invoked from network); 29 Jul 2016 18:18:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Jul 2016 18:18:03 -0000 Authentication-Results: pb1.pair.com smtp.mail=me@kelunik.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=me@kelunik.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.221 cause and error) X-PHP-List-Original-Sender: me@kelunik.com X-Host-Fingerprint: 81.169.146.221 mo4-p00-ob.smtp.rzone.de Received: from [81.169.146.221] ([81.169.146.221:9748] helo=mo4-p00-ob.smtp.rzone.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/60-35985-ADD9B975 for ; Fri, 29 Jul 2016 14:18:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1469816279; l=1540; s=domk; d=kelunik.com; h=Content-Type:Cc:To:Subject:Date:From:References:In-Reply-To: MIME-Version; bh=Ldb/mvSGn26OakWSneuWhAL+YzTMlW0g5RILwUAJuu4=; b=VeIVrq/Xg1h8vrpBKDZLZzbsEo2bcfL6QXzfIxy4bgvY5BH42Kkcedu7AHYW6vlmH/A Dos6qdtTkgrOMTD/rFqBWIHjHgjIOv7BsMSI0BIQIorgS5VZd9ULDxbV2ngJfFAIelzNQ IEcN+E5tiQVV/QzFOIEkTnL6iRU276DgSX8= X-RZG-AUTH: :IWkkfkWkbvHsXQGmRYmUo9mls2vWuiu+7SLGvomb4bl9EfHtO3A6 X-RZG-CLASS-ID: mo00 Received: from mail-wm0-f43.google.com ([74.125.82.43]) by smtp.strato.de (RZmta 38.13 AUTH) with ESMTPSA id U088cfs6TIHsLGS (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp384r1 with 384 ECDH bits, eq. 7680 bits RSA)) (Client did not present a certificate) for ; Fri, 29 Jul 2016 20:17:54 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id f65so299562007wmi.0 for ; Fri, 29 Jul 2016 11:17:54 -0700 (PDT) X-Gm-Message-State: AEkoouuPUQf9ugNosgN5uBhWashWbcM6KH+uY0ZodsPhcvzI0ySD/ZGt4NO1Z4jeig8gT3lciqK5ouQMhfMg2Q== X-Received: by 10.28.170.198 with SMTP id t189mr2402545wme.19.1469816274719; Fri, 29 Jul 2016 11:17:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.27.206 with HTTP; Fri, 29 Jul 2016 11:17:54 -0700 (PDT) In-Reply-To: References: Date: Fri, 29 Jul 2016 20:17:54 +0200 X-Gmail-Original-Message-ID: Message-ID: To: David Rodrigues Cc: Ryan Pallas , Timothy Younger , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11442ff8f100c80538ca44af Subject: Re: [PHP-DEV] optionally return class name from gettype From: me@kelunik.com (Niklas Keller) --001a11442ff8f100c80538ca44af Content-Type: text/plain; charset=UTF-8 > > Niklas Keller wrote: > > I'm not sure on the boolean through, I think a new function might be > better. > > In this point I desagree. > I think that boolean is the best way, mainly to avoid a new function > on userland. > It's like an "extension" for gettype(), and make senses just extend it. The issue is that it's not clear what this boolean means just from reading the code. If you follow Clean Code, you shouldn't have something like that, only in very, very rare cases. --001a11442ff8f100c80538ca44af--