Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94744
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKC-LS2iLjXHbVPAuk4J_uN0d1syc1-oxgUmwVS257uX5s1bdA@mail.gmail.com>
References: <CAKC-LS2iLjXHbVPAuk4J_uN0d1syc1-oxgUmwVS257uX5s1bdA@mail.gmail.com>
Date: Fri, 29 Jul 2016 08:03:57 -0600
Message-ID: <CAObuZdtOdgp54_9M5=tfGBChFn4gc+GKNrOxConcM23FSD6PUw@mail.gmail.com>
To: Timothy Younger <abacaphiliac@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1140e81ac728180538c6b8f8
Subject: Re: [PHP-DEV] optionally return class name from gettype
From: derokorian@gmail.com (Ryan Pallas)

--001a1140e81ac728180538c6b8f8
Content-Type: text/plain; charset=UTF-8

I love this idea (as I've written much the same code before), I do think it
will require a full RFC though.

On Fri, Jul 29, 2016 at 7:53 AM, Timothy Younger <abacaphiliac@gmail.com>
wrote:

> hi Internals Team,
>
> i find myself writing this line frequently in projects:
>
> is_object($value) ? get_class($value) : gettype($value);
>
> it seems i'm not the only one:
>
>
> https://github.com/search?l=php&q=get_class+gettype&ref=searchresults&type=Code&utf8=%E2%9C%93
>
> although it is small, it amounts to a lot of duplicated logic in need of
> testing. i'm looking to write that line, and its tests, one last time.
>
> i think it's a bit trivial to warrant a standalone lib, but might already
> exist or fit in some helper package.
>
> instead, what do you think about an optional param for the gettype method
> to provide this functionality? here's the new (hopefully
> backwards-compatible) behavior:
>
> var_dump(gettype(new \stdClass(), true));
> string(8) "stdClass"
>
> var_dump(gettype(new \stdClass()));
> string(6) "object"
>
> here's my commit, proposed for php/php-src:
>
>
> https://github.com/abacaphiliac/php-src/commit/f4e2fae9145cec5af94f197acf71dae02cd61b08
>
> and my commit's build on travis:
>
> https://travis-ci.org/abacaphiliac/php-src/builds/148218512
>
> any interest? if gettype isn't the right home for this logic, then perhaps
> someplace else?
>
> thank you.
> Tim Younger
>

--001a1140e81ac728180538c6b8f8--