Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94733 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27959 invoked from network); 28 Jul 2016 08:00:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jul 2016 08:00:08 -0000 Authentication-Results: pb1.pair.com smtp.mail=ben.coutu@zeyos.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ben.coutu@zeyos.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zeyos.com designates 159.122.110.40 as permitted sender) X-PHP-List-Original-Sender: ben.coutu@zeyos.com X-Host-Fingerprint: 159.122.110.40 mx.zeyos.com Received: from [159.122.110.40] ([159.122.110.40:41598] helo=mx.zeyos.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A0/20-25564-68BB9975 for ; Thu, 28 Jul 2016 04:00:07 -0400 Received: from mx.zeyos.com (mx.zeyos.com [127.0.0.1]) by mx.zeyos.com (Postfix) with ESMTP id 49967A3 for ; Thu, 28 Jul 2016 10:01:26 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mx.zeyos.com Received: from mx.zeyos.com ([127.0.0.1]) by mx.zeyos.com (mx.zeyos.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id okCEE31f_Zfg for ; Thu, 28 Jul 2016 10:01:26 +0200 (CEST) Received: from 127.0.0.1 (9a.08.9905.ip4.static.sl-reverse.com [5.153.8.154]) by mx.zeyos.com (Postfix) with ESMTPSA id 0ACDBA1; Thu, 28 Jul 2016 10:01:23 +0200 (CEST) Date: Thu, 28 Jul 2016 10:00:00 +0200 To: Xinchen Hui Cc: PHP Internals MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20160728080126.49967A3@mx.zeyos.com> Subject: Re: [PHP-DEV] Optimizing =?UTF-8?Q?array=5Freverse=20for=20packed=20hash?= =?UTF-8?Q?=20tables=20=28when=20preserve=5Fkeys=3Dfalse=29?= From: ben.coutu@zeyos.com (Benjamin Coutu) Hi Xinchen,=0A=0AThe code I used was simply derived from the code of the ar= ray_slice implementation (totally analogous).=0AMaybe your suggested change= s (check HASH_FLAG_PACKED fist + Z_TRY_ADDREF) should be carried over to ar= ray_slice then as well.=0A=0APlease go ahead and commit a patch, I'd prefer= to stick to reviewing for now.=0A=0AThanks,=0A=0ABen