Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94618 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99855 invoked from network); 21 Jul 2016 17:22:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jul 2016 17:22:08 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@fleshgrinder.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=php@fleshgrinder.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain fleshgrinder.com from 77.244.243.85 cause and error) X-PHP-List-Original-Sender: php@fleshgrinder.com X-Host-Fingerprint: 77.244.243.85 mx104.easyname.com Received: from [77.244.243.85] ([77.244.243.85:47499] helo=mx206.easyname.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BF/25-52781-DB401975 for ; Thu, 21 Jul 2016 13:22:07 -0400 Received: from cable-81-173-132-156.netcologne.de ([81.173.132.156] helo=[192.168.178.20]) by mx.easyname.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bQHfc-0006Ev-8y; Thu, 21 Jul 2016 17:22:00 +0000 Reply-To: internals@lists.php.net References: <7716d180-2365-efc9-e9b3-9fe0998e273b@fleshgrinder.com> To: Nikita Popov , PHP internals , Stanislav Malyshev Message-ID: <380f0dd7-ab26-87d8-6fef-ca2a8569eaa2@fleshgrinder.com> Date: Thu, 21 Jul 2016 19:21:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XOee5sdKdXOEFnGh7VV7VeHlHxSCRjoxv" Subject: Re: [PHP-DEV] [RFC] [Vote] var_info From: php@fleshgrinder.com (Fleshgrinder) --XOee5sdKdXOEFnGh7VV7VeHlHxSCRjoxv Content-Type: multipart/mixed; boundary="cInQlfxfgI2pQF1PKagHS2CuFGiXSSgp8" From: Fleshgrinder Reply-To: internals@lists.php.net To: Nikita Popov , PHP internals , Stanislav Malyshev Message-ID: <380f0dd7-ab26-87d8-6fef-ca2a8569eaa2@fleshgrinder.com> Subject: Re: [PHP-DEV] [RFC] [Vote] var_info References: <7716d180-2365-efc9-e9b3-9fe0998e273b@fleshgrinder.com> In-Reply-To: --cInQlfxfgI2pQF1PKagHS2CuFGiXSSgp8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Many thanks for the feedback to both of you. :) On 7/8/2016 11:54 PM, Nikita Popov wrote: > You are doing a callability check for all arrays and strings. I wouldn'= t be > comfortable passing any data that potentially derives from external sou= rces > (aka all data) to that function. E.g. this could trigger autoloading on= > user-provided values -- while we have some protections in place to avoi= d > the most egregious security vulnerabilities, I wouldn't be comfortable = with > that. There probably other funky things that can happen here. >=20 That is true for anything that uses is_callable anywhere. On 7/8/2016 11:54 PM, Nikita Popov wrote: > Lastly, I'll just leave this list of type-related improvements I'd actu= ally > like to see: > * Make is_object() return true for IncompleteClass. This is just > ridiculous. I care zero about the theoretical BC impact. I figured that this situation is on purpose and I don't think that it is ridiculous per se. It makes sense if is_object() is defined as only identifying valid objects (and incomplete class is by definition invalid)= =2E On 7/8/2016 11:54 PM, Nikita Popov wrote: > * Make gettype() return 'resource (unknown type)' instead of just > 'unknown type' for closed resources. This makes the output clear while > still leaving the closed resource distinction. Will prepare a PR. 8) On 7/8/2016 11:54 PM, Nikita Popov wrote: > * Normalize error message. IIRC currently our type error messages are > really weird, in that they use terms like "integer" which are not actua= lly > valid type hints (or have different meaning). Fixing this doesn't even = need > a proposal, just a PR. >=20 Definitely on my roadmap anyways and yes stas, this requires going through a sh**load of existing tests but it is definitely worth it. I will most probably start work on all of this this weekend after being on vacation for the last days. --=20 Richard "Fleshgrinder" Fussenegger --cInQlfxfgI2pQF1PKagHS2CuFGiXSSgp8-- --XOee5sdKdXOEFnGh7VV7VeHlHxSCRjoxv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXkQS3AAoJEOKkKcqFPVVr880P/12tkZhGhtDK5nXF8n3RPIwG mshxxQpV1qRRXgj5f+qluCoir9HLUgvxcVT7vCYZ3AjF6wij93F/5qu4ubqnafyu aN0EMQBSBspo+QkmCa9NuPuT0mN29IYLJcfe6QbQfAL5gtPbSV6cFSP7SXtdLHFb frzW+Lsyztdn2uN5ZlbKFYyiJhp+hjFplaSWyDP9cysdGEMNXH080Zmqohl5IZd4 e4ld6+LRb9mZv/9azzLQH27cwrOYwueL4Y+BhOUMCuxp3AiGRVw51sT4HsbUG7y+ bCsw3TKVf4IZVD4fc/mczO6Tz4YMOo0Jv49aCdEKfPNVNxYWPaG2VKw5b9z7GWkm qguPTzznv08fpKCqjfybQnKeFK5noojKmw/npUFq+/FGg71lSrMFNRTPL48e/+zu 4WVBObBgKPhX7zR1nXMcG0iXUz1Nedeq4ajUu9qerZLJZx9a2xtHaQBTayXSr2N6 0sI2Z5Mc+iZBwgwhe4g2wXCm0CoYNlyAwzT11jGTbsZZXogKYZK3p0IfWM7agkAN xynFJDESvjH5XjmgZ9Sx4t6yWNph79V10mnSYkYb579dm/CQqik/yJu1vwxiNB2c AxH2sY0GzYS3vQw7FlPClYbnMnWSB8PCEhBKzTYzl3zwq/yvbdS9pMQF5+Fvno3v zG4c9QYRj/cEJ3ceQhx+ =701e -----END PGP SIGNATURE----- --XOee5sdKdXOEFnGh7VV7VeHlHxSCRjoxv--