Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94616
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.15 as permitted sender)
To: =?UTF-8?Q?Pablo_S=c3=a1nchez?= <phackwer@gmail.com>,
 internals@lists.php.net
References: <CA+QymsvO5x7VgvWxCo956uhvzP_1B9qbL4svu4vgM556Q9gXBg@mail.gmail.com>
Message-ID: <6bc644e8-5aa5-67ae-c457-a5b5bb66cced@gmx.de>
Date: Thu, 21 Jul 2016 17:01:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <CA+QymsvO5x7VgvWxCo956uhvzP_1B9qbL4svu4vgM556Q9gXBg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: Greetings - need orientation about fix
From: cmbecker69@gmx.de (Christoph Becker)

On 20.07.2016 at 21:29, Pablo Sánchez wrote:

> I made a small fix/adjustment to lastInsertId on pdo_pgsql on branch 7.0.9.
> It builded ok, there's a PR for it (https://github.com/php/php-src/pull/2014)
> and I just wondered about if I should apply it on 7.1.0, 5.6.whatever, and
> 5.5.whatevertoo. The point about applying it to 7.1 seems obvious, but
> retro adjustments doesn't.

To which branch a PR should be applied to (and ideally developed
against) depends whether it is a simple bug fix, a security issue or a
new feature, and on the currently supported versions[1].

As this issue appears to be a bug, it should be applied to the PHP-5.6
branch, so please rebase your commits onto this branch (or open a new PR
against PHP-5.6).

In any way, never base a PR on a revision branch, such as PHP-7.0.9.

[1] <http://php.net/supported-versions.php>

-- 
Christoph M. Becker