Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94604
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.223.175 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAGa2bXbKcC5q__7rSzT4-QGrwDs1XvFoTH5w0xv2vL3QpHNukQ@mail.gmail.com>
References: <CAESVnVoBrtfWGF-Be+uXWwLNO3=JzuLBXyhW0Dpo-NvoskofQw@mail.gmail.com>
 <20160721000555.C7F861A810A0@dd1730.kasserver.com> <CAGa2bXbKcC5q__7rSzT4-QGrwDs1XvFoTH5w0xv2vL3QpHNukQ@mail.gmail.com>
Date: Wed, 20 Jul 2016 21:29:18 -0700
Message-ID: <CAESVnVoF3c_L+9TEqq3oE+9ee7NszOXcrK3QHgNtrz2QHuhyhA@mail.gmail.com>
To: Thomas Bley <mails@thomasbley.de>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Pipe Operator v2
From: pollita@php.net (Sara Golemon)

> On Thu, Jul 21, 2016 at 9:05 AM, Thomas Bley <mails@thomasbley.de> wrote:
> to me this code is perfectly readable and static code analysis is only complaining about missing semicolons at the end of the lines and short variable names:
>
> $x = loadConfig();
> $x = buildDic($x);
> $x = getApp($x)
> $x = getRouter($x)
> $x = getDispatcher($x, $request)
> $x = dispatchBusinessLogic($x, $request, new Response())
> $x = renderResponse($x)
> $x = buildPsr7Response($x)
> $response =emit($x);
>
A proper static analyzer would also not that $x is continuously
changing types, another heave code smell.

> I'm not sure if there is a ORM or database library out there which constructs
> SQL queries with non-oop calls, maybe you can give a real-world example.
>
The third example in the RFC (FBShipIt) shows this exact operator in a
real-world usage in "php-like" code.

-Sara