Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94547 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46101 invoked from network); 18 Jul 2016 06:24:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Jul 2016 06:24:52 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:49675] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3A/11-35561-0367C875 for ; Mon, 18 Jul 2016 02:24:50 -0400 Received: (qmail 13168 invoked by uid 89); 18 Jul 2016 06:24:45 -0000 Received: from unknown (HELO mail-qt0-f176.google.com) (yohgaki@ohgaki.net@209.85.216.176) by 0 with ESMTPA; 18 Jul 2016 06:24:45 -0000 Received: by mail-qt0-f176.google.com with SMTP id w38so87053326qtb.0 for ; Sun, 17 Jul 2016 23:24:45 -0700 (PDT) X-Gm-Message-State: ALyK8tKCT35i6tDeFHb3KyddA5TG0INW7N92jdh8XMS4K8y3xDrVAp/S37stHPMQwOt5pulJ78zDRFeRN7SGcA== X-Received: by 10.200.56.155 with SMTP id f27mr29884qtc.26.1468823079422; Sun, 17 Jul 2016 23:24:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.85.242 with HTTP; Sun, 17 Jul 2016 23:23:59 -0700 (PDT) In-Reply-To: References: Date: Mon, 18 Jul 2016 15:23:59 +0900 X-Gmail-Original-Message-ID: Message-ID: To: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [RFC][VOTE] Session ID without hashing From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi all and RM, On Sat, Jul 2, 2016 at 4:35 PM, Yasuo Ohgaki wrote: > Currently session module uses obsolete MD5 for session ID. With > CSPRNG, hashing is redundant and needless. It adds hash module > dependency and inefficient (There is no reason to use hash for CSPRNG > generated bytes). > > This proposal cleans up session code by removing hash. > > https://wiki.php.net/rfc/session-id-without-hashing > > I set vote requires 2/3 support. > Please describe the reason why when you against this RFC. Reasons are > important for improvements! The changes in the manual is committed. UPGRADING is written, PR branch is synced for merge. https://github.com/php/php-src/pull/1850 Should I merge or just telling "please merge" is OK? Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net