Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94525
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEDdnaW4oXhwjQ1hf3TwHL+qDM6PvKz+k_UhE=oATU3OP=EBZA@mail.gmail.com>
References: <CAEDdnaWVYbh=t1-bvDh9fixCoC7Be4asoEus=dRhGggx_9VLNg@mail.gmail.com>
 <CA+kxMuQg8o2ZUpMvB74E-Akq1W6JH-0w8b=7Dq510dmcfKqR3Q@mail.gmail.com> <CAEDdnaW4oXhwjQ1hf3TwHL+qDM6PvKz+k_UhE=oATU3OP=EBZA@mail.gmail.com>
Date: Sun, 17 Jul 2016 09:12:56 +0500
Message-ID: <CAEDdnaVJu_Lc7xakSbtDCNBdny9senCAiOxp0rhfFfs8YoxVog@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114a82f80c6b5e0537cd11b4
Subject: Re: [PHP-DEV] [RFC] New operator for context-dependent escaping
From: michael.vostrikov@gmail.com (Michael Vostrikov)

--001a114a82f80c6b5e0537cd11b4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

>
> 1. Is there any specific reason why we're using a class instead of
> functions to register a callable the same way it's done for exception
> handling or error handling? Hacking non FQN resolutions to inject another
> escaper ...
>

I would not call it 'hacking') This is exaclty the same as if we write
'PHPEscaper::escape()' manually in PHP context.
I didn't want to add many related items to a global namespace, and with
class it is possible to use autoloading.

2. Is there any rationale why we're using strings separated by '|' to pass
> context instead of an array? Ex.:
> <?* $str, ['js', 'html'] ?>
>

Yes, I thought about array. It can be added on a par with string. Strings
just looks more similar to escaping in template engines.

3. I think the default implementation should throw a more specific
> exception in case of unknown context (\PHP\EscapeException?)
> 4. This line on your patch is unnecessary
>

You are right, thanks. This commit is a concept, if RFC will be accepted, I
will prepare a patch with more correct code.
=E2=80=8B

--001a114a82f80c6b5e0537cd11b4--