Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94523
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEDdnaWVYbh=t1-bvDh9fixCoC7Be4asoEus=dRhGggx_9VLNg@mail.gmail.com>
References: <CAEDdnaWVYbh=t1-bvDh9fixCoC7Be4asoEus=dRhGggx_9VLNg@mail.gmail.com>
Date: Sat, 16 Jul 2016 23:49:15 -0400
Message-ID: <CAOsHV+tyJM41bRAEuKh2m+5QTLWzdSO_mSwZLMZrn7ChUaSKzQ@mail.gmail.com>
To: Michael Vostrikov <michael.vostrikov@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c1464b47856050537ccbdda
Subject: Re: [PHP-DEV] [RFC] New operator for context-dependent escaping
From: marcio.web2@gmail.com (Marcio Almada)

--94eb2c1464b47856050537ccbdda
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2016-07-16 11:33 GMT-04:00 Michael Vostrikov <michael.vostrikov@gmail.com>:
>
> Hello.
> I have created RFC about context-dependent escaping operator.
> https://wiki.php.net/rfc/escaping_operator
>
> Initial discussion was here: http://marc.info/?t=3D146619199100001


Hi,

A few possible RFC improvements:

1. Is there any specific reason why we're using a class instead of
functions to register a callable the same way it's done for exception
handling or error handling? Hacking non FQN resolutions to inject another
escaper implementation as in "<?php use MyEscaper as PHPEscaper; ?>" was a
creative idea but it seems inconsistent with the preferable "PHP way" to
handle these edge cases.

2 . Is there any rationale why we're using strings separated by '|' to pass
context instead of an array? Ex.:

<?* $str, ['js', 'html'] ?>

3. I think the default implementation should throw a more specific
exception in case of unknown context (\PHP\EscapeException?) -
currently it's throwing \Exception. The reason for that is because log
level and handling may be more severe in case of failing escaping.
Userland implementations should be encouraged to throw the same specific
exception too (documentation could enforce that).

4. This line on your patch is unnecessary:
https://github.com/michael-vostrikov/php-src/commit/571cd7c88488a08c82b10f0=
c3af559881f1a2951#diff-7eff82c2c5b45db512a9dc49fb990bb8R274

In general this RFC looks better than the expected considering the previous
discussions. Please, keep improving :)

Best,
M=C3=A1rcio.

--94eb2c1464b47856050537ccbdda--