Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94522
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.161.176 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEDdnaWVYbh=t1-bvDh9fixCoC7Be4asoEus=dRhGggx_9VLNg@mail.gmail.com>
References: <CAEDdnaWVYbh=t1-bvDh9fixCoC7Be4asoEus=dRhGggx_9VLNg@mail.gmail.com>
Date: Sat, 16 Jul 2016 21:24:49 +0100
Message-ID: <CA+kxMuQg8o2ZUpMvB74E-Akq1W6JH-0w8b=7Dq510dmcfKqR3Q@mail.gmail.com>
To: Michael Vostrikov <michael.vostrikov@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] New operator for context-dependent escaping
From: danack@basereality.com (Dan Ackroyd)

Hi Michael,

On 16 July 2016 at 16:33, Michael Vostrikov <michael.vostrikov@gmail.com> wrote:
> Hello.
> I have created RFC about context-dependent escaping operator.
> https://wiki.php.net/rfc/escaping_operator
>
> Initial discussion was here: http://marc.info/?t=146619199100001

I'm more than slightly sceptical about this RFC's chances, but to give
you some feedback, this bit is a bad pattern:

> bool PHPEscaper::registerHandler(string $context, callable $escaper_function)
>
> Registers new handler for a given context. If handler for this context is already
> registered, it returns false, on success registration returns true.

It would be better to return the previous handler, or NULL if one
wasn't set, in the same way as set_error_handler() does, and for the
same reasons.

Also, shouldn't these just be functions? Why is there a class involved
when it only has static functions/state?

cheers
Dan